Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find minimum Helm CLI version and add Make targets to check it. #1207

Closed
petewall opened this issue Feb 6, 2025 · 1 comment · Fixed by #1249
Closed

Find minimum Helm CLI version and add Make targets to check it. #1207

petewall opened this issue Feb 6, 2025 · 1 comment · Fixed by #1249

Comments

@petewall
Copy link
Collaborator

petewall commented Feb 6, 2025

Someone ran into this issue when building a new integration: helm/helm#5979
The fix is to upgrade to version 3.14 of the Helm cli, though it's not obvious that's the solution.

It'd be nice to have checks in our Makefiles that looks at Helm cli version and fails if it's below a certain threshold.
@petewall
Copy link
Collaborator Author

petewall commented Feb 6, 2025

Having this would make things easier for new contributors and reduce friction for development.

@petewall petewall linked a pull request Feb 18, 2025 that will close this issue
Add a check for the minimum required Helm cli version. #1249
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a check for the minimum required Helm cli version. grafana/k8s-monitoring-helm
1 participant
@petewall