feat(servicegraphs): Add support for db.system.name
#4656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamrajiv
requested review from
joe-elliott,
mdisibio,
mapno,
yvrhdn,
zalegrala,
electron0zero,
ie-pham,
stoewer and
javiermolinar
as code owners
|
|
iamrajiv
changed the title
db.system.name in service graphsdb.system.name in service graphs
iamrajiv
changed the title
db.system.name in service graphsdb.system.name
mapno
reviewed
Feb 4, 2025
Signed-off-by: iamrajiv <[email protected]>
|
@mapno i have updated the vendor can u check now |
|
Hi @iamrajiv. You cannot change an single vendor file like that. You need to update the dependency in |
rlankfo
reviewed
Feb 7, 2025
There was a problem hiding this comment.
The servicegraphconnector component in contrib adds a configuration option to set the database name attribute. Could we do the same here as well?
https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/connector/servicegraphconnector/config.go#L49-L51
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR adds support for the
db.system.nameattribute introduced in OpenTelemetry Semantic Conventions v1.30.0. The change maintains backward compatibility while supporting the new attribute name.Which issue(s) this PR fixes:
Fixes #4640
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]