Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Options for setting MySQL connection lifetime and other parameters #113

Open
sharathjag opened this issue Jan 6, 2025 · 4 comments
Open
Labels
enhancement New feature or request evaluation needed

Comments

@sharathjag
Copy link

Would it be possible for exposing driver parameters in Database struct?

We would need to refined access mysql driver parameters to test our use-cases and are currently limited to using connection string.
Would it be possible to expose these settings.

Happy to create a PR.

@alex-dubrouski
Copy link

To provide more details. Actual applications may have different connection pool settings, and in many cases they have enabled connection recycling. Connection recycling might significantly distort throughput data if connection lifetime is short.
We need a way to explicitly set these settings that are available in Go SQL driver and document this feature for users, so they can simulate these scenarios.

@szkiba szkiba added enhancement New feature or request evaluation needed labels Feb 13, 2025
@szkiba
Copy link
Contributor

szkiba commented Feb 13, 2025

I've added it to the tasks, we'll investigate it.

@sharathjag
Copy link
Author

thanks @szkiba
I have a draft https://github.com/grafana/xk6-sql/compare/main...sharathjag:xk6-sql:conn-options?expand=1
LMK what you think of the general direction. I can refine and create a PR

@sharathjag
Copy link
Author

@szkiba any updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request evaluation needed
Projects
None yet
Development

No branches or pull requests

3 participants