Add interface IDs directly to Typechain generated factories (#1240)

* feat(interfaces): add interface IDs directly to generated factory classes

- Replace generateInterfaceIds.js with addInterfaceIds.ts utility
- Add interface IDs as static properties on Typechain factory classes
- Export utility functions via src/utils.ts for programmatic use
- Add ts-node dependency to run TypeScript build scripts
- Remove separate interfaceIds.ts constants file

* refactor(interfaces): improve addInterfaceIds code quality

Address Copilot review feedback for PR 1240:
- Replace magic numbers with named constants for better readability
- Replace fragile regex-based JSON parsing with Function constructor
  for more robust ABI parsing that handles complex TypeScript syntax

* refactor(interfaces): address additional code review feedback

Add validation and improve code safety:
- Add explicit justification comments for Function constructor usage
- Add validation to ensure regex replacement succeeds before writing file
- Fix ESLint warning by using const instead of let for content variable
- Return false and log warning if metadata injection pattern not found

* fix(horizon): fix failing testSlash_RoundDown_TokensThawing_Delegation fuzz test

The test was failing when fuzzer generated inputs that left less than
MIN_DELEGATION shares after undelegating but more than 0.

Added constraint to ensure after undelegation either:
- All tokens are undelegated (remaining = 0), which is valid, OR
- At least MIN_DELEGATION remains, which is the minimum required

The root cause: The contract correctly enforces that delegators must
either fully exit (0 shares) or maintain at least MIN_DELEGATION shares.
The test was missing this constraint, allowing the fuzzer to generate
invalid intermediate amounts like 0.95e18 shares remaining.

Fixes the intermittent CI failure on fuzzing seed 0xd5262092.

* refactor(interfaces): improve error handling and indentation matching

- Extract indentation from existing code instead of hardcoding 2 spaces
- Track and report processing failures separately from skipped files
- Return null from addInterfaceIdToFactory on errors instead of false
- Throw error if any files failed processing to fail the build
- Change warning to error for pattern match failures

* chore: switching to version of fix already on other branch

Author: RembrandtK

packages/horizon/test/unit/staking/slash/slash.t.sol

@@ -172,6 +172,10 @@ contract HorizonStakingSlashTest is HorizonStakingTest {
         vm.assume(delegationTokensToSlash <= delegationTokens);
         vm.assume(delegationTokensToUndelegate <= delegationTokens);
         vm.assume(delegationTokensToUndelegate > 0);
+        vm.assume(
+            delegationTokensToUndelegate == delegationTokens ||
+                MIN_DELEGATION <= delegationTokens - delegationTokensToUndelegate
+        );
 
         resetPrank(users.delegator);
         _delegate(users.indexer, subgraphDataServiceAddress, delegationTokens, 0);

packages/interfaces/package.json

@@ -12,13 +12,21 @@
       "types": "./dist/src/index.d.ts",
       "default": "./dist/src/index.js"
     },
+    "./types": {
+      "types": "./dist/types/index.d.ts",
+      "default": "./dist/types/index.js"
+    },
     "./types-v5": {
       "types": "./dist/types-v5/index.d.ts",
       "default": "./dist/types-v5/index.js"
     },
     "./wagmi": {
       "types": "./dist/wagmi/generated.d.ts",
       "default": "./dist/wagmi/generated.js"
+    },
+    "./utils": {
+      "types": "./dist/src/utils.d.ts",
+      "default": "./dist/src/utils.js"
     }
   },
   "files": [
@@ -47,21 +55,22 @@
     "prepublishOnly": "pnpm run build"
   },
   "devDependencies": {
+    "@ethersproject/abi": "5.7.0",
+    "@ethersproject/providers": "5.7.2",
     "@nomicfoundation/hardhat-toolbox": "^4.0.0",
     "@openzeppelin/contracts": "3.4.2",
     "@openzeppelin/contracts-upgradeable": "3.4.2",
     "@typechain/ethers-v5": "^10.2.1",
     "@wagmi/cli": "^2.3.1",
     "ethers": "catalog:",
     "ethers-v5": "npm:[email protected]",
-    "@ethersproject/abi": "5.7.0",
-    "@ethersproject/providers": "5.7.2",
     "hardhat": "catalog:",
     "hardhat-ignore-warnings": "catalog:",
     "markdownlint-cli": "catalog:",
     "prettier": "catalog:",
     "prettier-plugin-solidity": "catalog:",
     "solhint": "catalog:",
+    "ts-node": "catalog:",
     "typechain": "^8.3.2",
     "viem": "^2.31.7"
   }

packages/interfaces/scripts/build.sh

@@ -64,8 +64,13 @@ find_files() {
 log_info "📦 Compiling contracts with Hardhat..."
 pnpm hardhat compile $([[ "$VERBOSE" != "true" ]] && echo "--quiet")
 
-# Step 1.5: Generate interface IDs
-node scripts/generateInterfaceIds.js
+# Step 1.5: Add interface IDs to generated factory files (only if needed)
+missing_ids=$(grep -rL "static readonly interfaceId" types/factories --include="*__factory.ts" 2>/dev/null | wc -l)
+
+if [[ $missing_ids -gt 0 ]]; then
+    # Slow operation, only run if needed
+    npx ts-node scripts/utils/addInterfaceIds.ts types/factories
+fi
 
 # Step 2: Generate types (only if needed)
 log_info "🏗️  Checking type definitions..."