Unable to set @graphql-hive/client token in firebase function

[kdawgwilk]

For context firebase functions require you to load secrets at runtime but the functions themselves get built so the code is partially executed. So when trying to build this firebase functions project:

const hiveToken = defineSecret('HIVE_TOKEN');

const graphqlRequestHandler = createYoga({
  schema,
  graphqlEndpoint: '*',
  plugins: [useYogaHive({ enabled: true, token: hiveToken.value(), usage: true })],
});

export const graphql = onRequest({ secrets: [hiveToken] }, graphqlRequestHandler);

I get the following error because of the hiveToken.value() call during function deployment:

Error: Cannot access the value of secret "HIVE_TOKEN" during function deployment. Secret values are only available at runtime.

[kdawgwilk]

I even tried the following approach and still it complains about accessing the secret during deployment

let hivePlugin: Plugin | null = null;

const initHivePlugin = () => {
  if (!hivePlugin) {
    hivePlugin = useYogaHive({ enabled: true, token: hiveToken.value(), usage: true });
  }
  return hivePlugin;
};

const hivePluginWrapper: Plugin = {
  onSchemaChange(context) {
    return initHivePlugin().onSchemaChange?.(context);
  },
  onParams(context) {
    return initHivePlugin().onParams?.(context);
  },
  onParse(context) {
    return initHivePlugin().onParse?.(context);
  },
  onExecute(context) {
    return initHivePlugin().onExecute?.(context);
  },
  onResultProcess(context) {
    return initHivePlugin().onResultProcess?.(context);
  },
};

export const graphqlRequestHandler = createYoga({
  schema,
  graphqlEndpoint: '*',
  plugins: [hivePluginWrapper],
});

[n1ru4l]

@kdawgwilk have you tried to lazily create the yoga instance upon the incoming request?

[kdawgwilk]

Yeah my current implementation is the following. I did struggle with getting TS happy but this is working

const yogaRequestHandler = (token: string) =>
  createYoga({
    schema,
    graphqlEndpoint: '*',
    plugins: [useYogaHive({ enabled: true, token, usage: true })],
  });

export const graphqlRequestHandler = (req: FunctionRequest, res: Express.Response) => {
  const yoga = yogaRequestHandler(hiveToken.value());
  // @ts-expect-error This is a valid Express handler but TS is not happy with it
  return yoga(req, res);
};

Not sure on what the performance hit will be to create the client lazily. It would be nice to let the token param be a string or function that gets called lazily

[kdawgwilk]

I am now experiencing memory leak issues that appear to be related to how i am lazily creating the yoga instance on every request. See this memory profiler screenshot (darker orange shows the differences in memory. Any other ideas here would be greatly appreciated.