Self-hosted CDN worker should have an env for KV cache URL (CloudFlare R2)

[noghartt]

I'm trying to approach the setup of a CDN worker based on packages/services/cdn-worker, but it seems that part of the logic is based on the key validation using https://key-cache.graphql-hive.com:

console/packages/services/cdn-worker/src/key-validation.ts

Line 52 in fdbe817

'https://key-cache.graphql-hive.com',

For self-hosted usage, I do believe that would be a good idea to move this hardcoded URL into a env itself. Maybe KV_STORAGE_BASE_URL or something like that.

[noghartt]

Also, sharing other thing I found, which I do believe it falls and it's being impacted by this:

console/packages/services/server/src/index.ts

Lines 620 to 643 in c1d9c05

	const artifactHandler = createArtifactRequestHandler({
	isKeyValid: createIsKeyValid({
	artifactStorageReader,
	analytics: null,
	breadcrumb(message: string) {
	server.log.debug(message);
	},
	getCache: null,
	waitUntil: null,
	captureException(error) {
	captureException(error, {
	extra: {
	source: 'artifactRequestHandler',
	},
	});
	},
	}),
	artifactStorageReader,
	isAppDeploymentActive: createIsAppDeploymentActive({
	artifactStorageReader,
	getCache: null,
	waitUntil: null,
	}),
	});

On the index.ts from server, it's being the same createIsKeyValid curried function from the cdn-worker, considering that the URL is hardcoded, for self-hosted solution, all the artifacts/* API handlers could be broken?

console/packages/services/server/src/index.ts

Line 654 in c1d9c05

const response = await artifactRouteHandler.handleNodeRequest(req);

[n1ru4l]

Hey @noghartt would you be interested in helping us out with this one?

[noghartt]

Hey @noghartt would you be interested in helping us out with this one?

Hey @n1ru4l, of course! Will be opening a PR with the fix on that today!

Thanks!

[noghartt]

Hey @n1ru4l, just updating here, I opened the PR adding those changes here. Can I get a review, please?

Also, I approach this ensure that it won't add any kind of breaking change into the old code, that's why I put it over a conditional flow, instead of just a hardcoded env.

(If there's any other issue where I can help, feel free to tag me 🙏)