Improve coverage

Author: oliemansm

graphql-webclient-spring-boot-autoconfigure/src/test/java/graphql/kickstart/spring/webclient/boot/OAuth2ClientRegistrationRepositoryConfigurationTest.java

@@ -0,0 +1,44 @@
+package graphql.kickstart.spring.webclient.boot;
+
+import static org.junit.jupiter.api.Assertions.*;
+
+import java.util.Set;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+
+class OAuth2ClientRegistrationRepositoryConfigurationTest {
+
+  private OAuth2ClientRegistrationRepositoryConfiguration configuration;
+
+  @BeforeEach
+  void setup() {
+    configuration = new OAuth2ClientRegistrationRepositoryConfiguration();
+  }
+
+  @Test
+  void clientRegistrationRepository_nullRegistration_returnsNull() {
+    var properties = new OAuth2ClientRegistrationProperties();
+    var repository = configuration.clientRegistrationRepository(properties);
+    assertNull(repository);
+  }
+
+  @Test
+  void clientRegistrationRepository_withRegistration_returns() {
+    var properties = new OAuth2ClientRegistrationProperties();
+    properties.setClientId("client-id");
+    properties.setClientSecret("client-secret");
+    properties.setRedirectUri("redirect-uri");
+    properties.setScope(Set.of("profile"));
+    properties.setClientName("client-name");
+    properties.setAuthorizationUri("authorization-uri");
+    properties.setTokenUri("token-uri");
+    properties.setUserInfoUri("user-info-uri");
+    properties.setJwkSetUri("jwk-set-uri");
+    properties.setProvider("provider");
+    properties.setUserNameAttribute("username-attribute");
+    properties.setIssuerUri("issuer-uri");
+    var repository = configuration.clientRegistrationRepository(properties);
+    assertNotNull(repository);
+  }
+
+}

graphql-webclient/src/main/java/graphql/kickstart/spring/webclient/boot/GraphQLRequestBuilder.java

@@ -18,11 +18,6 @@ public class GraphQLRequestBuilder {
   GraphQLRequestBuilder() {
   }
 
-  public GraphQLRequestBuilder header(String name, String value) {
-    headers.add(name, value);
-    return this;
-  }
-
   public GraphQLRequestBuilder header(String name, String... values) {
     headers.addAll(name, Arrays.asList(values));
     return this;

graphql-webclient/src/main/java/graphql/kickstart/spring/webclient/boot/GraphQLResponse.java

@@ -25,7 +25,7 @@ public class GraphQLResponse {
 
     JsonNode tree = readTree(rawResponse);
     errors = readErrors(tree);
-    data = tree.hasNonNull("data") ? tree.get("data") : null;
+    data = tree.get("data");
   }
 
   private JsonNode readTree(String rawResponse) {
@@ -52,7 +52,7 @@ private JavaType constructListType(Class<?> type) {
   }
 
   public <T> T get(String fieldName, Class<T> type) {
-    if (data != null && data.hasNonNull(fieldName)) {
+    if (data.hasNonNull(fieldName)) {
       return objectMapper.convertValue(data.get(fieldName), type);
     }
     return null;
@@ -63,14 +63,14 @@ public <T> T getFirst(Class<T> type) {
   }
 
   private Optional<JsonNode> getFirstDataEntry() {
-    if (data != null && !data.isEmpty()) {
+    if (!data.isEmpty()) {
       return Optional.ofNullable(data.fields().next().getValue());
     }
     return Optional.empty();
   }
 
   public <T> List<T> getList(String fieldName, Class<T> type) {
-    if (data != null && data.hasNonNull(fieldName)) {
+    if (data.hasNonNull(fieldName)) {
       return convertList(data.get(fieldName), type);
     }
     return emptyList();

graphql-webclient/src/test/java/graphql/kickstart/spring/webclient/boot/GraphQLRequestBuilderTest.java

@@ -0,0 +1,23 @@
+package graphql.kickstart.spring.webclient.boot;
+
+import static org.junit.jupiter.api.Assertions.*;
+
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+
+class GraphQLRequestBuilderTest {
+
+  private GraphQLRequestBuilder builder;
+
+  @BeforeEach
+  void setup() {
+    builder = GraphQLRequest.builder();
+  }
+
+  @Test
+  void operationName_addsToRequest() {
+    GraphQLRequest request = builder.operationName("some-operation").build();
+    assertEquals("some-operation", request.getRequestBody().getOperationName());
+  }
+
+}