Add check for newline in quoted strings

tailhook · tailhook · commit 869bc2d4c811 · 2018-02-05T01:17:26.000+02:00
diff --git a/src/tokenizer.rs b/src/tokenizer.rs
@@ -203,14 +203,17 @@ impl<'a> TokenStream<'a> {
                             '"' => {
                                 return Ok((StringValue, idx+1));
                             }
-                            // TODO(tailhook) ensure SourceCharacter
-                            // and not newline
+                            '\n' => {
+                                return Err(Error::unexpected_message(
+                                    "unterminated string value"));
+                            }
                             _ => {}
                         }
                         prev_char = cur_char;
                     }
+                    return Err(Error::unexpected_message(
+                        "unterminated string value"));
                 }
-                return Ok((Name, self.buf.len() - self.off));
             }
             _ => return Err(Error::unexpected_message(
                 format_args!("unexpected character {:?}", cur_char))),

Original file line number	Diff line number	Diff line change
`@@ -203,14 +203,17 @@ impl<'a> TokenStream<'a> {`
`203`	`203`	`'"' => {`
`204`	`204`	`return Ok((StringValue, idx+1));`
`205`	`205`	`}`
`206`		`- // TODO(tailhook) ensure SourceCharacter`
`207`		`- // and not newline`
	`206`	`+ '\n' => {`
	`207`	`+ return Err(Error::unexpected_message(`
	`208`	`+ "unterminated string value"));`
	`209`	`+ }`
`208`	`210`	`_ => {}`
`209`	`211`	`}`
`210`	`212`	`prev_char = cur_char;`
`211`	`213`	`}`
	`214`	`+ return Err(Error::unexpected_message(`
	`215`	`+ "unterminated string value"));`
`212`	`216`	`}`
`213`		`- return Ok((Name, self.buf.len() - self.off));`
`214`	`217`	`}`
`215`	`218`	`_ => return Err(Error::unexpected_message(`
`216`	`219`	`format_args!("unexpected character {:?}", cur_char))),`