Fix incorrect FormattedCompletedResult fields and add a FormattedPendingResult (#4481)

jerelmiller · web-flow · commit c6c424439bdf · 2025-09-22T09:34:12.000+02:00
Fixes #4333 This change fixes the fields in `FormattedCompletedResult` to match `CompletedResult` (i.e. `id` and `errors`) using the `Formatted*` type variants. This change also adds a `FormattedPendingResult` as an counterpart to `PendingResult` to match the type patterns already established with other `Formatted*` types. I ran into this issue when working on adding support for the new incremental format in Apollo Client (apollographql/apollo-client#12906).
diff --git a/src/execution/types.ts b/src/execution/types.ts
@@ -162,9 +162,8 @@ export interface CompletedResult {
 }
 
 export interface FormattedCompletedResult {
-  path: ReadonlyArray<string | number>;
-  label?: string;
-  errors?: ReadonlyArray<GraphQLError>;
+  id: string;
+  errors?: ReadonlyArray<GraphQLFormattedError>;
 }
 
 export function isPendingExecutionGroup(

Original file line number	Diff line number	Diff line change
`@@ -162,9 +162,8 @@ export interface CompletedResult {`
`162`	`162`	`}`
`163`	`163`
`164`	`164`	`export interface FormattedCompletedResult {`
`165`		`- path: ReadonlyArray<string \| number>;`
`166`		`- label?: string;`
`167`		`- errors?: ReadonlyArray<GraphQLError>;`
	`165`	`+ id: string;`
	`166`	`+ errors?: ReadonlyArray<GraphQLFormattedError>;`
`168`	`167`	`}`
`169`	`168`
`170`	`169`	`export function isPendingExecutionGroup(`