v1.2.2 “Stand” – Fixes 1. Html embedding into the controller and 2. ResolveDescriptor logic is duplication across two controllers #7
greenarmor
announced in
Announcements
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
v1.2.2 “Stand” – Fixes:
The inline landing page markup in Home::index confirms the reviewer: @giangvincent's concern about HTML embedded in the controller.
Commit d042df9
The resolveDescriptor logic is duplicated across two controllers, matching the comment about duplicate methods
Commit bac7e36
Thanks to @giangvincent
This discussion was created from the release v1.2.2 “Stand” – Fixes 1. Html embedding into the controller and 2. ResolveDescriptor logic is duplication across two controllers.
Beta Was this translation helpful? Give feedback.
All reactions