Extend with suggestions from Greg

Author: Ashley Frieze

docs/JunitRules.md

@@ -80,10 +80,6 @@ The rules are applied and the test object created just in time for each atomic t
 [SpringSpecJUnitStyle](../src/test/java/specs/SpringSpecJUnitStyle.java) and
 [SpringSpecWithRuleClasses](../src/test/java/specs/SpringSpecWithRuleClasses.java)
 
-
-
-
-
 ### What is Supported
 
 * `@ClassRule` is applied
@@ -93,6 +89,7 @@ The rules are applied and the test object created just in time for each atomic t
   * `TestRule`s are applied at the level of each atomic test
   * `MethodRule`s are applied at the level of each atomic test
 * `junitMixin` is implemented to be thread-safe
+* `junitMixin` provides an overload for unboxing the supplier - `junitMixin(SomeClass.class, SomeInterface.class)` - if your mixin has an interface to it. See also [`let` - when get is getting you down.](VariablesAndValues.md)
 
 ### What is not supported
 

docs/VariablesAndValues.md

@@ -109,3 +109,14 @@ it("can use the object as though it was not in a supplier", () -> {
   assertThat(list.get(0), is("Hello"));
 });
 ```
+
+The `unbox` method can be used with any `Supplier<>`. There is also an overload of `let` as a short form for this:
+
+```java
+List<String> list = let(ArrayList::new, List.class);
+
+it("can use the object as though it was not in a supplier", () -> {
+  list.add("Hello");
+  assertThat(list.get(0), is("Hello"));
+});
+```

src/main/java/com/greghaskins/spectrum/Configure.java

@@ -1,5 +1,7 @@
 package com.greghaskins.spectrum;
 
+import static com.greghaskins.spectrum.Unboxer.unbox;
+
 import com.greghaskins.spectrum.internal.DeclarationState;
 import com.greghaskins.spectrum.internal.configuration.BlockFocused;
 import com.greghaskins.spectrum.internal.configuration.BlockIgnore;
@@ -11,7 +13,6 @@
 import com.greghaskins.spectrum.internal.junit.Rules;
 
 import java.time.Duration;
-import java.util.concurrent.TimeUnit;
 import java.util.function.Supplier;
 
 public interface Configure {
@@ -154,4 +155,22 @@ static FilterConfigurationChain excludeTags(String... tagsToExclude) {
   static <T> Supplier<T> junitMixin(final Class<T> classWithRules) {
     return Rules.applyRules(classWithRules, DeclarationState.instance()::addHook);
   }
+
+  /**
+   * Uses the given class as a mix-in for JUnit rules to be applied. These rules will cascade down
+   * and be applied at the level of specs or atomic specs. Provide a proxy to the eventual mix-in
+   * via the interface given.
+   *
+   * @param classWithRules Class to create and apply rules to for each spec.
+   * @param interfaceToReturn the type of interface the caller requires the proxy object to be
+   * @param <T>            type of the mixin object
+   * @param <R>            the required type at the consumer - allowing for generic interfaces
+   *                       (e.g. <code>List&lt;String&gt;</code>)
+   * @param <S>            type of the interface common to the rules object and the proxy
+   * @return a proxy to the rules object
+   */
+  static <T extends S, R extends S, S> R junitMixin(final Class<T> classWithRules,
+      final Class<S> interfaceToReturn) {
+    return unbox(junitMixin(classWithRules), interfaceToReturn);
+  }
 }

src/main/java/com/greghaskins/spectrum/Spectrum.java

@@ -1,5 +1,7 @@
 package com.greghaskins.spectrum;
 
+import static com.greghaskins.spectrum.Unboxer.unbox;
+
 import com.greghaskins.spectrum.dsl.specification.Specification;
 import com.greghaskins.spectrum.internal.DeclarationState;
 import com.greghaskins.spectrum.internal.Suite;
@@ -234,6 +236,33 @@ public static <T> Supplier<T> let(final com.greghaskins.spectrum.ThrowingSupplie
     return Specification.let(supplier);
   }
 
+  /**
+   * A value that will be fresh within each spec and cannot bleed across specs. This is provided
+   * as a proxy to a lazy loading object, with the interface given.
+   *
+   * <p>
+   * Note that {@code let} is lazy-evaluated: the internal {@code supplier} is not called until the first
+   * time it is used.
+   * </p>
+   *
+   * @param <T>      The type of value
+   * @param <R>      the required type at the consumer - allowing for generic interfaces
+   *                 (e.g. <code>List&lt;String&gt;</code>)
+   * @param <S>      the type of the value's interface.
+   * @param supplier {@link com.greghaskins.spectrum.ThrowingSupplier} function that either
+   *                 generates the value, or throws a {@link Throwable}
+   * @param interfaceToUse an interface type, that is supported by the supplied object and can be used
+   *                       to access it through the supplier without having to call {@link Supplier#get()}
+   * @return proxy to the object supplied, using the interface given
+   * @see Specification#let
+   * @see Unboxer#unbox(Supplier, Class)
+   */
+  public static <T extends S, R extends S, S> R let(
+      final com.greghaskins.spectrum.ThrowingSupplier<T> supplier,
+      Class<S> interfaceToUse) {
+    return unbox(let(supplier), interfaceToUse);
+  }
+
   private final Suite rootSuite;
 
   /**

src/main/java/com/greghaskins/spectrum/Unboxer.java

@@ -24,7 +24,7 @@ public interface Unboxer {
    */
   @SuppressWarnings("unchecked")
   static <T extends S, R extends S, S> R unbox(Supplier<T> supplier, Class<S> asClass) {
-    return (R) Proxy.newProxyInstance(asClass.getClassLoader(), new Class[] {asClass},
+    return (R) Proxy.newProxyInstance(asClass.getClassLoader(), new Class<?>[] {asClass},
         (Object proxy, Method method, Object[] args) -> method.invoke(supplier.get(), args));
   }
 }

src/test/java/specs/JUnitRuleExample.java

@@ -21,10 +21,19 @@
 
 @RunWith(Spectrum.class)
 public class JUnitRuleExample {
+  public interface JUnitTempFolderInterface {
+    TemporaryFolder getTempFolder();
+  }
+
   // mixins for the Spectrum native style of mixin
-  public static class TempFolderRuleMixin {
+  public static class TempFolderRuleMixin implements JUnitTempFolderInterface {
     @Rule
     public TemporaryFolder tempFolderRule = new TemporaryFolder();
+
+    @Override
+    public TemporaryFolder getTempFolder() {
+      return tempFolderRule;
+    }
   }
 
   // alternative morphology of providing a rule - see http://junit.org/junit4/javadoc/4.12/org/junit/Rule.html
@@ -95,12 +104,28 @@ public static void beforeClass() {
       it("has access to an initialised object", () -> {
         assertNotNull(tempFolderRuleMixin.get().getFolder().getRoot());
       });
+
+      describe("A spec with a rule mix-in via interface", () -> {
+        JUnitTempFolderInterface tempFolderGetter =
+            junitMixin(TempFolderRuleMixin.class, JUnitTempFolderInterface.class);
+
+        it("has access to the rule-provided object at the top level", () -> {
+          checkCanUseTempFolderAndRecordWhatItWas(ruleProvidedFoldersSeen,
+              tempFolderGetter.getTempFolder());
+        });
+
+      });
     });
   }
 
   private void checkCanUseTempFolderAndRecordWhatItWas(Set<File> filesSeen,
       Supplier<TempFolderRuleMixin> tempFolderRuleMixin) {
-    assertNotNull(tempFolderRuleMixin.get().tempFolderRule.getRoot());
-    filesSeen.add(tempFolderRuleMixin.get().tempFolderRule.getRoot());
+    checkCanUseTempFolderAndRecordWhatItWas(filesSeen, tempFolderRuleMixin.get().tempFolderRule);
+  }
+
+  private void checkCanUseTempFolderAndRecordWhatItWas(Set<File> filesSeen,
+      TemporaryFolder folder) {
+    assertNotNull(folder.getRoot());
+    filesSeen.add(folder.getRoot());
   }
 }

src/test/java/specs/UnboxerSpecs.java

@@ -36,6 +36,15 @@ public class UnboxerSpecs {
       });
     });
 
+    describe("Using let overload", () -> {
+      List<String> list = let(ArrayList::new, List.class);
+
+      it("can use the object as though it was not in a supplier", () -> {
+        list.add("Hello");
+        assertThat(list.get(0), is("Hello"));
+      });
+    });
+
     describe("Using unboxer with variable", () -> {
       Variable<ArrayList<String>> listVariable = new Variable<>(new ArrayList<>());
       List<String> list = unbox(listVariable, List.class);