Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issues or new features? #2

Open
grll opened this issue Jan 13, 2025 · 4 comments
Open

issues or new features? #2

grll opened this issue Jan 13, 2025 · 4 comments

Comments

@grll
Copy link
Owner

grll commented Jan 13, 2025

Hi all, have you been able to try it out ? Is it working for your use case?

I have done some testing but not very extensive so let me know if you face any issue, happy to help!

Also if you have ideas on most wanted features let me know.

@joejoe2
Copy link

joejoe2 commented Feb 21, 2025

@grll I am wondering can smolagents use this with sse transport to call remote tool ?

@joejoe2
Copy link

joejoe2 commented Mar 5, 2025

Thank you, I have seen the sse update. Can we also have auto recconection ? Is there a possibility that remote mcp server reboot and update their tools ?

@grll
Copy link
Owner Author

grll commented Mar 5, 2025

@joejoe2 hi thanks, for the interest. To be honest I am not really sure what happens in case of interruption of connection with SSE is it something you experienced? If I remember correctly I thought the mcp protocol handle capabilities changes? Is there already a documented approach to handle reconnection ? It seems to me this should be something maybe handled by the mcp sse client ?

@joejoe2
Copy link

joejoe2 commented Mar 5, 2025

I am testing below code. It seems stop working after I reboot the fast mcp server, so i am not sure this is related to mcp client or not.

adapter_instance = MCPAdapt(
    {"url": "http://127.0.0.1:8000/sse"}, SmolAgentsAdapter()
)

with adapter_instance as tool_collection:
    print(tool_collection)
    time.sleep(30)  # update tools and reboot my dev fast mcp server here, get log "Error in sse_reader:"
    print(adapter_instance.tools())  # does not seem to reconnect, tools unchanged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants