Merge pull request #27 from groupthinking/copilot/sub-pr-26

Address code review feedback: strengthen type guards and remove unsafe assertions

Author: groupthinking

package-lock.json

@@ -10,7 +10,7 @@ import { XMCPServer } from './mcp/server.js';
 async function main() {
   // Redirect console.log to stderr so it doesn't conflict with
   // MCP StdioServerTransport which uses stdout for protocol messages
-  console.log = (...args: any[]) => console.error(...args);
+  console.log = (...args: unknown[]) => console.error(...args);
 
   console.log('═══════════════════════════════════════════════════');
   console.log('  MyXstack - Autonomous AI Agent on X (Twitter)');

src/index.ts

@@ -102,7 +102,11 @@ export class AutonomousAgent {
         const excess = this.processedMentions.size - AutonomousAgent.MAX_PROCESSED_MENTIONS;
         const iter = this.processedMentions.values();
         for (let i = 0; i < excess; i++) {
-          this.processedMentions.delete(iter.next().value as string);
+          const { value, done } = iter.next();
+          if (done) {
+            break;
+          }
+          this.processedMentions.delete(value);
         }
       }
     } catch (error) {

src/services/agent.ts

@@ -91,6 +91,11 @@ export class XAPIClient {
         return null;
       }
 
+      if (!Array.isArray(response.data)) {
+        console.warn('X API thread response data is not an array');
+        return null;
+      }
+
       return this.parseThread(response.data);
     } catch (error) {
       console.error('Error fetching thread:', error);