-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gcp/observability: implement logging via binarylog #5196
Conversation
@dfawley PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick review!
I addressed all comments (or at least try to come up with a solution).
PTALA.
@dfawley How's the review going? Feel free to post partial or high-level comments. Let me know how can I push this PR forward. |
@dfawley PTALA. I have updated this PR according to our offline discussion. The data race around binarylog logger is resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick review! PTALAAA.
Bump. |
* Includes generalized MethodConfig * Includes updated config definition * Includes custom tags and location tags
The plugin registers a binarylog Logger and consumes a binarylog Sink directly from the internal API, without any temporary file in between.
The designed usage looks like:
There is still vagueness inside the proto definition (grpc/grpc-proto#103, pending to be formed as gRFC). As discussed before, I hid them as internal module. The translation between binary log entry and GrpcLogRecord is almost 1-to-1, but misses details like:
Previous attempt: #5157
RELEASE NOTES: none