Skip to content

Commit 44a715f

Browse files
committed
11243::RLS cleanups
1 parent b1665ff commit 44a715f

File tree

2 files changed

+5
-7
lines changed

2 files changed

+5
-7
lines changed

rls/src/main/java/io/grpc/rls/LinkedHashLruCache.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -345,8 +345,4 @@ public String toString() {
345345
.toString();
346346
}
347347
}
348-
349-
public final void setEstimatedSizeBytes(long newSizeBytes) {
350-
this.estimatedSizeBytes = newSizeBytes;
351-
}
352348
}

rls/src/test/java/io/grpc/rls/LinkedHashLruCacheTest.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -285,20 +285,22 @@ public void testFitToLimitUsingReSize() {
285285
}
286286

287287
@Test
288-
public void testFitToLimitWithEstimatedSizeBytes() {
288+
public void testFitToLimitWithEntry() {
289289
Entry entry1 = new Entry("Entry1", ticker.read() + 10,4);
290290
Entry entry2 = new Entry("Entry2", ticker.read() + 20,2);
291291
Entry entry3 = new Entry("Entry3", ticker.read() + 30,1);
292+
Entry entry4 = new Entry("Entry4", ticker.read() + 20,2);
292293

293294
cache.cache(1, entry1);
294295
cache.cache(2, entry2);
295296
cache.cache(3, entry3);
296297

297298
assertThat(cache.estimatedSize()).isEqualTo(2);
298-
cache.setEstimatedSizeBytes(7);
299+
cache.cache(4, entry4);
299300

301+
assertThat(cache.estimatedSize()).isEqualTo(3);
300302
assertThat(cache.estimatedMaxSizeBytes()).isEqualTo(5);
301-
assertThat(cache.fitToLimit()).isEqualTo(true);
303+
assertThat(cache.fitToLimit()).isEqualTo(false);
302304
assertThat(cache.estimatedSizeBytes()).isEqualTo(5);
303305
}
304306
}

0 commit comments

Comments
 (0)