Skip to content

Commit 034e5cf

Browse files
authored
Fix bad time unit types in wait_for_namespace_active (#212)
See #203 (review) Error sample: ```pytb I1030 12:10:45.628975 140704582733824 k8s.py:1302] Waiting for namespace stk-server-ns-wait to become active Traceback (most recent call last): File "/Users/sergiitk/Development/psm-interop/bin/run_test_server.py", line 166, in <module> app.run(main) File "/Users/sergiitk/Development/psm-interop/venv/lib/python3.10/site-packages/absl/app.py", line 308, in run _run_main(main, args) File "/Users/sergiitk/Development/psm-interop/venv/lib/python3.10/site-packages/absl/app.py", line 254, in _run_main sys.exit(main(argv)) File "/Users/sergiitk/Development/psm-interop/bin/run_test_server.py", line 152, in main server_runner.run(**run_kwargs) File "/Users/sergiitk/Development/psm-interop/framework/test_app/runners/k8s/k8s_xds_server_runner.py", line 216, in run super().run() File "/Users/sergiitk/Development/psm-interop/framework/test_app/runners/k8s/k8s_base_runner.py", line 199, in run self.k8s_namespace.wait_for_namespace_active() File "/Users/sergiitk/Development/psm-interop/framework/infrastructure/k8s.py", line 1303, in wait_for_namespace_active retryer = retryers.constant_retryer( File "/Users/sergiitk/Development/psm-interop/framework/helpers/retryers.py", line 115, in constant_retryer stops.append(stop.stop_after_delay(timeout.total_seconds())) AttributeError: 'int' object has no attribute 'total_seconds' ```
1 parent 965ea21 commit 034e5cf

File tree

1 file changed

+2
-2
lines changed
  • framework/infrastructure

1 file changed

+2
-2
lines changed

framework/infrastructure/k8s.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1296,8 +1296,8 @@ def _namespace_active(cls, namespace: V1Namespace) -> bool:
12961296

12971297
def wait_for_namespace_active(
12981298
self,
1299-
timeout: _timedelta = WAIT_SHORT_TIMEOUT_SEC,
1300-
retry_wait: _timedelta = WAIT_SHORT_SLEEP_SEC,
1299+
timeout: _timedelta = WAIT_SHORT_TIMEOUT,
1300+
retry_wait: _timedelta = WAIT_SHORT_SLEEP,
13011301
) -> None:
13021302
logger.info("Waiting for namespace %s to become active", self.name)
13031303
retryer = retryers.constant_retryer(

0 commit comments

Comments
 (0)