Skip to content

Workflow yaml file created with Windows (CR) line breaks #48

@Krinkle

Description

@Krinkle

In grunt-contrib-qunit, I tried to update grunt-contrib-internal from v4 to latest v6 and noticed that after running ./node_modules/.bin/grunt build-contrib (from a container with Node.js 10, and Debian 9) it created the .github/workflows/test.yml file as follows:

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
new file mode 100644
index 0000000..6869813
--- /dev/null
+++ b/.github/workflows/test.yml
@@ -0,0 +1,39 @@
+name: Tests^M
+^M
+on: [push, pull_request]^M
+^M
+env:^M
+  FORCE_COLOR: 2^M
+^M
+jobs:^M
+  run:^M
+    name: Node ${{ matrix.node }} on ${{ matrix.os }}^M
+    runs-on: ${{ matrix.os }}^M
+^M
+    strategy:^M
+      fail-fast: false^M
+      matrix:^M
+        node: [10, 12, 14]^M
+        os: [ubuntu-latest, windows-latest]^M
+^M
+    steps:^M
+      - name: Clone repository^M
+        uses: actions/checkout@v2^M
+^M
+      - name: Set up Node.js^M
+        uses: actions/setup-node@v2^M
+        with:^M
+          node-version: ${{ matrix.node }}^M
+^M
+      - name: Install npm dependencies^M
+        run: npm ci^M
+^M
+      - name: Run tests^M
+        run: npm test^M
+^M
+      # We test multiple Windows shells because of prior stdout buffering issues^M
+      # filed against Grunt. https://github.com/joyent/node/issues/3584^M
+      - name: Run PowerShell tests^M
+        run: "npm test # PowerShell" # Pass comment to PS for easier debugging^M
+        shell: powershell^M
+        if: startsWith(matrix.os, 'windows')^M

And it modified CONTRIBUTING.md as well:

-… for information on contributing to this project.
+… for information on contributing to this project.^M

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions