[BUG] Regression: 17.0.0 RC 1 works, but 17.2.1 RC 2 and newer crashes immediately upon opening the app

[antermin]

Describe the Bug
On my device, Orbot-17.0.0-RC-1-tor.0.4.7.11-fullperm-universal-release is the last known good build.
Orbot-17.2.1-RC-2-tor-0.4.8.7-fullperm-universal-release is the first known bad build.
The latest version, 17.3.2 RC 1, also doesn't work.

Notes:

• I didn't test the beta versions.
• I didn't test the 17.1.0 and 17.1.1 series since I couldn't find a compatible build for my device's architecture for on the Releases page.

To Reproduce
Steps to reproduce the behavior:

1. Uninstall Orbot
2. Install the latest version of Orbot
3. Tap Orbot in app drawer to open the app
4. The app crashes immediately

Expected Behavior
The app should not crash.

What Custom Configuration Do You Use?
N/A, I haven't changed any configuration.
I uninstalled Orbot before installing the latest version of Orbot to make sure that it is a clean install.

Smartphone (please complete the following information):

• Device: Asus Zenfone 2 Deluxe
• OS: Android 6 (stock ROM)
• Version: Orbot-17.3.2-RC-1-tor-0.4.8.12-fullperm-universal-release

Additional Context
My device's architecture is x86 / x86-64. I wonder if this may have caused the regression.

[n8fr8]

Anyway you can get a crash log to us?

[antermin]

How do I get a crash log? (e.g. What command should I use?)

As newer versions of Orbot crashes immediately, I don't even have any chance to click on any buttons in Orbot. Android shows a popup that the app has stopped as soon as I open Orbot.

[antermin]

@n8fr8

Hello, I am willing to get a crash log so that developers can look into this issue, but can you please give me instructions on getting a crash log?

[meenbeese]

@n8fr8

Hello, I am willing to get a crash log so that developers can look into this issue, but can you please give me instructions on getting a crash log?

Please check this: https://www.xda-developers.com/how-to-take-logs-android/

[antermin]

Thanks @meenbeese - to be clear, just the system log (adb logcat -d > logcat.txt) is enough, right? Or are other types of logs needed as well?

Also, do I have to post the log publicly?
I am concerned that the log may reveal the apps I use and lead to privacy issues (e.g. people may be able to find out where I am from based on the information in the log).
Therefore, if it is possible, I would like to send the log to developers in a private way.

[n8fr8]

You can email the crashlog to [email protected] or just pull out lines that seem relevant to the crash

[n8fr8]

Just to add detail, this is an Intel Android device, and it is running Android 6.

The crash is likely related to one of those things.

[n8fr8]

@antermin while we would love to support all chips and OS versions, it is increasingly difficult for us to support older devices like this one. Since you do care about privacy and security, it may be best for you to try to upgrade to something newer and more secure.

[antermin]

Using Orbot-17.4.1-BETA-4-tor-0.4.8.13-fullperm-universal-release.apk, I observed:

 java.lang.NoSuchMethodError: No static method fromHtml(Ljava/lang/String;I)Landroid/text/Spanned; in class Landroid/text/Html; or its super classes (declaration 
                            of 'android.text.Html' appears in /system/framework/framework.jar)

I wonder if 20805be is related?

Full `pidcat org.torproject.android` output

                            Process org.torproject.android created for service org.torproject.android/.service.OrbotService
                            PID: 4378   UID:    GIDs: 

   WM-WrkMgrInitializer  D  Initializing WorkManager with default configuration.
WM-PackageManagerHelper  D  Skipping component enablement for androidx.work.impl.background.systemjob.SystemJobService
          WM-Schedulers  D  Created SystemJobScheduler and enabled SystemJobService
   WM-ForceStopRunnable  D  The default process name was not specified.
                         D  Performing cleanup operations.
               Monotype  V  SetAppTypeFace- try to flip, app = org.torproject.android
                         V      Typeface getFontPathFlipFont - systemFont = default#default
WM-PackageManagerHelper  D  Skipping component enablement for androidx.work.impl.background.systemalarm.RescheduleReceiver
      AppCompatDelegate  D  Checking for metadata for AppLocalesMetadataHolderService : Service not found
                    art  W  Before Android 4.1, method android.graphics.PorterDuffColorFilter androidx.vectordrawable.graphics.drawable.VectorDrawableCompat.updateTintFilter(android.graphic
                            s.PorterDuffColorFilter, android.content.res.ColorStateList, android.graphics.PorterDuff$Mode) would have incorrectly overridden the package-private method in an
                            droid.graphics.drawable.Drawable
               Monotype  V  SetAppTypeFace- try to flip, app = org.torproject.android
                         V      Typeface getFontPathFlipFont - systemFont = default#default
               RootBeer  I  LOOKING FOR BINARY: /data/local/su Absent :(
                         I  LOOKING FOR BINARY: /data/local/bin/su Absent :(
                         I  LOOKING FOR BINARY: /data/local/xbin/su Absent :(
                         I  LOOKING FOR BINARY: /sbin/su Absent :(
                         I  LOOKING FOR BINARY: /su/bin/su Absent :(
                         I  LOOKING FOR BINARY: /system/bin/su Absent :(
                         I  LOOKING FOR BINARY: /system/bin/.ext/su Absent :(
                         I  LOOKING FOR BINARY: /system/bin/failsafe/su Absent :(
                         I  LOOKING FOR BINARY: /system/sd/xbin/su Absent :(
                         I  LOOKING FOR BINARY: /system/usr/we-need-root/su Absent :(
                         I  LOOKING FOR BINARY: /system/xbin/su Absent :(
                         I  LOOKING FOR BINARY: /cache/su Absent :(
                         I  LOOKING FOR BINARY: /data/su Absent :(
                         I  LOOKING FOR BINARY: /dev/su Absent :(
                         I  LOOKING FOR BINARY: /vendor/bin/su Absent :(
                         I  LOOKING FOR BINARY: /system/sbin/su Absent :(
                    art  I  Rejecting re-init on previously-failed class java.lang.Class<org.torproject.android.ui.OrbotTileService>
                         I  Rejecting re-init on previously-failed class java.lang.Class<org.torproject.android.ui.OrbotTileService>
                         I  Rejecting re-init on previously-failed class java.lang.Class<org.torproject.android.ui.OrbotTileService>
         OpenGLRenderer  D  Use EGL_SWAP_BEHAVIOR_PRESERVED: true
         AndroidRuntime  D  Shutting down VM
                         E  FATAL EXCEPTION: main
                         E  Process: org.torproject.android, PID: 4378
                         E  java.lang.NoSuchMethodError: No static method fromHtml(Ljava/lang/String;I)Landroid/text/Spanned; in class Landroid/text/Html; or its super classes (declaration 
                            of 'android.text.Html' appears in /system/framework/framework.jar)
                         E      at org.torproject.android.ConnectFragment$$ExternalSyntheticApiModelOutline0.m(D8$$SyntheticClass:0)
                         E      at org.torproject.android.ConnectFragment.doLayoutOff(ConnectFragment.kt:250)
                         E      at org.torproject.android.OrbotActivity$orbotServiceBroadcastReceiver$1.onReceive(OrbotActivity.kt:222)
                         E      at androidx.localbroadcastmanager.content.LocalBroadcastManager.executePendingBroadcasts(LocalBroadcastManager.java:319)
                         E      at androidx.localbroadcastmanager.content.LocalBroadcastManager$1.handleMessage(LocalBroadcastManager.java:127)
                         E      at android.os.Handler.dispatchMessage(Handler.java:102)
                         E      at android.os.Looper.loop(Looper.java:148)
                         E      at android.app.ActivityThread.main(ActivityThread.java:5480)
                         E      at java.lang.reflect.Method.invoke(Native Method)
                         E      at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:726)
                         E      at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:616)
         OpenGLRenderer  I  Initialized EGL, version 1.4
                         W  Failed to choose config with EGL_SWAP_BEHAVIOR_PRESERVED, retrying without...
                Process  I  Sending signal. PID: 4378 SIG: 9

                            Process org.torproject.android (PID: 4378) ended

[n8fr8]

Definitely an Android 6 issue as well. This is a problem with us overaggresively updating "Deprecated Code" when it still functions just fine. I will see what we can do.

[meenbeese]

Definitely an Android 6 issue as well. This is a problem with us overaggresively updating "Deprecated Code" when it still functions just fine. I will see what we can do.

I have seen this error highlighted in Android Studio before. It used to work fine until we lowered the minSdk to 21, at which point I started seeing the error. I can look at it this weekend.

[meenbeese]

This is why lowering the minSdk is not trivial and I can't fully justify it in our case. Hopefully, we can bump it to 23 again soon.

[syphyr]

@meenbeese the minSDK for Orbot should always match the minSDK for tor-android.

[antermin]

Are there any APKs available for trying the fix in #1256?