Skip to content

Commit c5906c2

Browse files
Copilottig
andauthored
#4329—Major Terminal.Gui v2 Architecture Modernization: Application Decoupling, Terminology Improvements, and Nullable Migration (#4338)
* Initial plan * Add comprehensive terminology proposal for Application.Top/Toplevel renaming Co-authored-by: tig <[email protected]> * Add terminology proposal summary document Co-authored-by: tig <[email protected]> * Add before/after comparison document for terminology proposal Co-authored-by: tig <[email protected]> * Add index document for terminology proposal Co-authored-by: tig <[email protected]> * Add Mermaid diagrams visualizing the terminology proposal Co-authored-by: tig <[email protected]> * Move terminology docs to docfx/docs per CONTRIBUTING.md guidelines Co-authored-by: tig <[email protected]> * Update terminology proposal to reflect recent modernization (post-MainLoop removal) Co-authored-by: tig <[email protected]> * Update terminology proposal - validate against recent driver refactoring changes Co-authored-by: tig <[email protected]> * Update proposal after massive v2_develop modernization - TopLevels now public, RunState→SessionToken Co-authored-by: tig <[email protected]> * Update proposal: RunStack → SessionStack to align with SessionToken terminology Co-authored-by: tig <[email protected]> * Phase 1: Core API rename - Application.Top→Current, TopLevels→SessionStack Co-authored-by: tig <[email protected]> * Phase 2: Fix test compilation errors for renamed properties Co-authored-by: tig <[email protected]> * Phase 3: Update documentation files with new terminology Co-authored-by: tig <[email protected]> * Refactor generic type names and remove unused field Renamed generic type parameters in `Dim` and `Pos` classes for clarity: - `T` was renamed to `TDim` in `Dim.Has` method. - `T` was renamed to `TPos` in `Pos.Has` method. Updated type casting and pattern matching logic to reflect these changes. Removed the unused `_stopAfterFirstIteration` field from the `ApplicationImpl` class to clean up the codebase. * Increase minimum code coverage target to 75% Updated the `codecov.yml` configuration file to raise the `project.default.target` value from 70% to 75%, enforcing stricter code coverage requirements for the overall project. * Add comprehensive unit tests for ApplicationImpl Begin/End logic Added ApplicationImplBeginEndTests with 16 tests covering: - Begin/End argument validation - SessionStack push/pop operations - Current property management - Balanced Begin/End enforcement - Multiple nested Begin/End scenarios - ResetState cleanup behavior - Toplevel activation/deactivation - SessionToken management Tests validate the fragile state management logic in ApplicationImpl.Lifecycle.cs and ApplicationImpl.Run.cs to catch regressions in Current/SessionStack handling. Co-authored-by: tig <[email protected]> * Refactor ApplicationImplBeginEndTests to work with ApplicationImpl instances directly Tests now: - Create ApplicationImpl instances directly instead of using global Application - Use try-finally blocks to ensure Shutdown() is always called - Work with app.Init() and app.Shutdown() properly - 13 of 16 tests passing (3 tests need adjustment for ResetState behavior) Tests validate fragile Begin/End state management logic without polluting global Application state. Co-authored-by: tig <[email protected]> * Fix ApplicationImplBeginEndTests: Remove explicit ResetState calls, rely on Shutdown Per maintainer feedback: - Tests should not call ResetState explicitly if they call Shutdown (Shutdown calls ResetState) - Removed all explicit app.ResetState() calls from tests - Tests now only call Shutdown in finally blocks for cleanup - Ensured toplevels are disposed BEFORE Shutdown to satisfy DEBUG_IDISPOSABLE assertions - Fixed test cleanup order to prevent ResetState assertion failures - All 16 tests now pass successfully ResetState is idempotent - the issue was tests calling it unnecessarily and with incorrect disposal ordering. Co-authored-by: tig <[email protected]> * Phase 1: Enable nullable by default, add directives to all files - Added <Nullable>enable</Nullable> to Terminal.Gui.csproj - Removed #nullable enable from 37 files (now redundant with project setting) - Added #nullable disable to 170 files that don't have nullable enabled yet - Build successful with 279 nullable warnings (expected) Breakdown of files with #nullable disable: - 27 in Views/ directory (will remain disabled per plan) - 143 outside Views/ (need to be fixed in subsequent commits) Next: Systematically fix nullable issues in non-View files. Co-authored-by: tig <[email protected]> * Phase 2: Remove nullable disable from all non-View files - COMPLETE! - Removed #nullable disable from 142 non-View files - All non-View code is now nullable-enabled - Build successful with 0 errors, only 1 unrelated warning - Created NULLABLE_VIEWS_REMAINING.md documenting the 121 View files still with nullable disable Nullable cleanup summary: ✅ App/: 25 files - nullable enabled ✅ Configuration/: 24 files - nullable enabled ✅ ViewBase/: 30 files - nullable enabled ✅ Drivers/: 25 files - nullable enabled ✅ Drawing/: 18 files - nullable enabled ✅ FileServices/: 7 files - nullable enabled ✅ Input/: 6 files - nullable enabled ✅ Text/: 5 files - nullable enabled ✅ Resources/: 3 files - nullable enabled ⏸️ Views/: 121 files - remain disabled (as requested) Total: 143 files nullable-enabled, 121 View files remain disabled. Co-authored-by: tig <[email protected]> * WIP: fixing nullability issues. * Fixed final nullability issues. * Moved Arrangment tests * Refactor and improve modularity across multiple classes Refactored `FillRectangles` in `RegionScenario` and `Region` to accept an `IDriver` parameter, reducing reliance on global state. Updated `ApplicationImpl` to replace static method calls with instance methods for better encapsulation. Renamed `Toplevel` to `Current` in `IPopover` and related classes for clarity. Simplified `LineCanvas` methods by removing unnecessary `IDriver` parameters. Added `Id` and `App` properties to `View` for better state management and unique identification. Streamlined the `Driver` property in `View` with a concise getter. Improved formatting and consistency across files, including `Region` and `IntersectionRuneResolver`. Enhanced thread safety in `Region` and cleaned up redundant code. Updated tests to align with interface changes and ensure compatibility. * Refactor to make IDriver dependency explicit Updated `AnsiEscapeSequenceRequest.Send` to accept an `IDriver?` parameter, replacing reliance on `Application.Driver`. Refactored `AnsiRequestScheduler` methods (`SendOrSchedule`, `RunSchedule`, and private `Send`) to propagate the `IDriver?` parameter, ensuring explicit driver dependency. Modified `DriverImpl.QueueAnsiRequest` to pass `this` to `SendOrSchedule`. Updated `AnsiRequestSchedulerTests` to reflect new method signatures, passing `null` for the driver parameter where applicable. Added `<param>` documentation for new parameters to improve clarity. These changes enhance flexibility, maintainability, and testability by reducing reliance on global state and allowing driver substitution in tests. * WIP: Started migrating to View.App Refactored `ApplicationImpl` to ensure proper handling of the `App` property for `Toplevel` instances, improving modularity. Replaced direct references to `Application` with `App` in `Border`, `ShadowView`, and other classes to enhance flexibility and maintainability. Introduced `GetApp` in `View` to allow overrides for retrieving the `App` instance. Updated `Adornment` to use this method. Moved mouse event subscriptions in `Border` to `BeginInit` for proper lifecycle management. Updated unit tests in `ArrangementTests` to use `App.Mouse` instead of `Application.Mouse`, ensuring alignment with the refactored design. Added `BeginInit` and `EndInit` calls for proper initialization during tests. Removed redundant code and improved test assertions. * WIP: Next set of View.App changes Updated `SetClipToScreen`, `SetClip`, and `GetClip` methods to accept an `IDriver` parameter, replacing reliance on the global `Application.Driver`. This improves modularity, testability, and reduces implicit global state usage. - Updated `Driver` property in `View` to use `App?.Driver` as fallback. - Refactored `DimAuto` to use `App?.Screen.Size` with a default for unit tests. - Updated all test cases to align with the new method signatures. - Performed general cleanup for consistency and readability. * Adds View clip tests. * Merged * Merged * wip * Fixed test bug. * Refactored Thickness.Draw to require driver. * Made TextFormatter.Draw require driver. * Code cleanup. * Un did stoopid idea. * Decouped Application.Navigation * MASSIVE - Almost completely decoupled Application from View etc... * Obsolete * Missed some * More cleanup and decoupling. Refactor `ToString` and remove legacy code Refactored `ToString` implementations across `Application`, `DriverImpl`, and `IDriver` to improve consistency and maintainability. Removed the legacy `ToString(IDriver? driver)` method and its associated references. Simplified `ToString` in `DriverImpl` to generate a string representation of the `Contents` buffer. Replaced redundant XML documentation with `<inheritdoc/>` tags to reduce duplication. Cleaned up unused `global using` directives and removed deprecated methods and properties, including `Screen`, `SetCursorVisibility`, and `IsRuneSupported`. Updated test cases in `GuiTestContext` and `DriverAssert` to use the new `ToString` implementation. Improved error messages for better debugging output. Streamlined LINQ queries and removed redundant checks for better readability and performance. Enhanced maintainability by decluttering the codebase, aligning namespaces, and consolidating related changes. * Changes before error encountered Co-authored-by: tig <[email protected]> * Update docfx/docs to document View.App architecture and instance-based patterns Updated 16 documentation files to reflect the major architectural changes: NEW FILES: - application.md: Comprehensive deep dive on decoupled Application architecture UPDATED FILES: - View.md: Documents View.App property, GetApp(), and instance-based patterns - navigation.md: Shows View.App usage instead of static Application - drivers.md: Documents View.Driver and GetDriver() patterns - keyboard.md: Event handling through View.App - mouse.md: Mouse event handling via View.App - arrangement.md: Updated code examples to use View.App - drawing.md: Rendering examples with instance-based API - cursor.md: Cursor management through View.App - multitasking.md: SessionStack and session management via View.App - Popovers.md: Popover patterns with View.App - cancellable-work-pattern.md: Updated examples - command.md: Command pattern with View.App context - config.md: Configuration access through View.App - migratingfromv1.md: Migration guide for static→instance patterns - newinv2.md: Documents new instance-based architecture All code examples now demonstrate the instance-based API (view.App.Current) instead of obsolete static Application references. Documentation accurately reflects the massive architectural decoupling achieved in this PR. Co-authored-by: tig <[email protected]> * Add `ToAnsi` support for ANSI escape sequence generation Introduced `ToAnsi` in `IDriver` and `IOutput` interfaces to generate ANSI escape sequences representing the terminal's current state. This enables serialization of terminal content for debugging, testing, and exporting. Implemented `ToAnsi` in `DriverImpl` and `FakeOutput`, supporting both 16-color and RGB modes. Refactored `OutputBase` with helper methods `BuildAnsiForRegion` and `AppendCellAnsi` for efficient ANSI generation. Enhanced `GuiTestContext` with `AnsiScreenShot` for capturing terminal state during tests. Added `ToAnsiTests` for comprehensive validation, including edge cases, performance, and wide/Unicode character handling. Updated documentation to reflect `ToAnsi` functionality and modernized driver architecture. Improved testability, modularity, and performance while removing legacy driver references. * Improve null safety and cleanup in GuiTestContext Enhanced null safety across `GuiTestContext` and `GuiTestContextTests`: - Replaced `a` with `app` for better readability in tests. - Added null checks (`!`, `?.`) to prevent potential null reference exceptions. - Removed redundant `WaitIteration` and duplicate `ScreenShot` calls. Improved error handling and robustness: - Updated shutdown logic to use null-safe calls for `RequestStop` and `Shutdown`. - Applied null-safe invocation for `_applicationImpl.Invoke`. General cleanup: - Removed redundant method calls and improved naming consistency. - Ensured better maintainability and adherence to best practices. * Refactor docs: remove deprecated files, update architecture Removed outdated documentation files related to the terminology proposal (`terminology-before-after.md`, `terminology-diagrams.md`, `terminology-index.md`, `terminology-proposal-summary.md`, `terminology-proposal.md`) from the `Docs` project. These files were either deprecated or consolidated into other documentation. Updated `application.md`: - Added a "View Hierarchy and Run Stack" section with a Mermaid diagram to illustrate the relationship between the view hierarchy and the application session stack. - Added a "Usage Example Flow" section with a sequence diagram to demonstrate the flow of running and stopping views. These changes improve clarity, streamline documentation, and align with the finalized terminology updates for the `Application.Current` and `Application.SessionStack` APIs. * Refactor Init/Run methods to simplify driver handling The `Init` method in `Application` and `IApplication` now accepts only an optional `driverName` parameter, removing the `IDriver` parameter. This simplifies initialization by relying on driver names to determine the appropriate driver. The `Run` methods have been updated to use `driverName` instead of `driver`, ensuring consistency with the updated `Init` method. Replaced redundant inline documentation with `<inheritdoc>` tags to improve maintainability and consistency. Legacy `Application` methods (`Init`, `Shutdown`, `Run`) have been marked as `[Obsolete]` to signal their eventual deprecation. Test cases have been refactored to align with the updated `Init` method signature, removing unused `driver` parameters. Documentation files have also been updated to reflect these API changes. These changes improve clarity, reduce complexity, and ensure a more consistent API design. * Refactor: Introduce Application.Create() factory method Introduced a new static method `Application.Create()` to create instances of `IApplication`, replacing direct instantiation of `ApplicationImpl`. This enforces a cleaner, recommended pattern for creating application instances. Made the `ApplicationImpl` constructor `internal` to ensure `Application.Create()` is used for instance creation. Refactored test cases across multiple files to use `Application.Create()` instead of directly instantiating `ApplicationImpl`. Simplified object initialization in tests using target-typed `new()` expressions. Updated documentation and examples in `application.md` to reflect the new instance-based architecture and highlight its benefits, such as supporting multiple applications with different drivers. Improved code readability, formatting, and consistency in tests and documentation. Aligned `ApplicationImplBeginEndTests` to use `IApplication` directly, adhering to the new architecture. * Added `Application.StopAll` and fixed coupling issues. Refactored `ApplicationImpl` to use an instance-based approach, replacing the static singleton pattern and Lazy<T>. Introduced `SetInstance` for configuring the singleton instance and updated tests to use `ApplicationImpl.Instance` or explicitly set the `Driver` property. Enabled nullable reference types across the codebase, updating fields and variables to nullable types where applicable. Added null checks to improve safety and prevent runtime errors. Refactored timeout management by introducing tokens for `Application.AddTimeout` and adding a `StopAll` method to `TimedEvents` for cleanup. Updated tests to use `System.Threading.Timer` for independent watchdog timers. Removed legacy code, improved logging for error cases, and updated view initialization to explicitly set `App` or `Driver` in tests. Enhanced test coverage and restructured `ScrollSliderTests` for better readability. Performed general code cleanup, including formatting changes, removal of unused imports, and improved naming consistency. * Refactor: Transition to IApplication interface Refactored the codebase to replace the static `Application` class with the `IApplication` interface, improving modularity, testability, and maintainability. Updated methods like `Application.Run`, `RequestStop`, and `Init` to use the new interface. Marked static members `SessionStack` and `Current` as `[Obsolete]` and delegated their functionality to `ApplicationImpl.Instance`. Updated XML documentation to reflect these changes. Simplified code by removing redundant comments, unused code, and converting methods like `GetMarginThickness` to single-line expressions. Improved null safety with null-conditional operators in `ToplevelTransitionManager`. Enhanced consistency with formatting updates, logging improvements, and better error handling. Updated `Shortcut` and other classes to align with the new interface-based design. Made breaking changes, including the removal of the `helpText` parameter in the `Shortcut` constructor. Updated `Wizard`, `Dialog`, and `GraphView` to use `IApplication` methods. Adjusted `ViewportSettings` and `HighlightStates` for better behavior. * Enhance null-safety and simplify codebase Improved null-safety by adopting nullable reference types and adding null-forgiving operators (`!`) where appropriate. Replaced direct method calls with null-safe calls using the null-conditional operator (`?.`) to prevent potential `NullReferenceException`. Removed default parameter values in test methods to enforce explicit parameter passing. Refactored test classes to remove unnecessary dependencies on `ITestOutputHelper`. Fixed a bug in `WindowsOutput.cs` by setting `_force16Colors` to `false` to avoid reliance on a problematic driver property. Updated `SessionTokenTests` to use null-forgiving operators for clarity in intentional null usage. Simplified graph and UI updates by ensuring safe access to properties and methods. Cleaned up namespaces and removed unused `using` directives for better readability. Updated `Dispose` methods to use null-safe calls and replaced nullable driver initialization with non-nullable initialization in `ScrollSliderTests` to ensure proper instantiation. * Refactor test code to use nullable `App` property Replaced direct `Application` references with `App` property across test classes to improve encapsulation and robustness. Updated `GuiTestContext` to use a nullable `App` property, replacing `_applicationImpl` for consistency. Refactored key event handling to use `App.Driver` and revised `InitializeApplication` and `CleanupApplication` methods to ensure safe usage of the nullable `App` property. Updated `Then` callbacks to explicitly pass `App` for clarity. Replaced `Application.QuitKey` with `context.App?.Keyboard.RaiseKeyDownEvent` to ensure context-specific event handling. Refactored `EnableForDesign` logic in `MenuBarv2Tests` and `PopoverMenuTests` to operate on the correct application instance. Improved null safety in test assertions and revised `RequestStop` and `Shutdown` calls to use `App?.RequestStop` and `App?.Shutdown`. Updated navigation logic to use `Terminal.Gui.App.Application` for namespace consistency. Enhanced exception handling in the `Invoke` method and performed general cleanup to align with modern C# practices, improving maintainability and readability. * Commented out exception handling in Application.Shutdown The `try-catch` block around `Application.Shutdown` was commented out, disabling the logging of exceptions thrown after a test exited. This change removes the `catch` block that used `Debug.WriteLine` for logging. The `finally` block remains intact, ensuring cleanup operations such as clearing `View.Instances` and resetting the application state are still executed. * Fixes #4394 - Changing Theme at Runtime does not Update Some Properties * Tweaks to config format. --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: Tig <[email protected]> Co-authored-by: tig <[email protected]>
1 parent 0995148 commit c5906c2

File tree

591 files changed

+8845
-4432
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

591 files changed

+8845
-4432
lines changed

Examples/CommunityToolkitExample/Program.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ private static void Main (string [] args)
1616
Services = ConfigureServices ();
1717
Application.Init ();
1818
Application.Run (Services.GetRequiredService<LoginView> ());
19-
Application.Top?.Dispose ();
19+
Application.Current?.Dispose ();
2020
Application.Shutdown ();
2121
}
2222

Examples/ReactiveExample/Program.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ private static void Main (string [] args)
1616
RxApp.MainThreadScheduler = TerminalScheduler.Default;
1717
RxApp.TaskpoolScheduler = TaskPoolScheduler.Default;
1818
Application.Run (new LoginView (new LoginViewModel ()));
19-
Application.Top.Dispose ();
19+
Application.Current.Dispose ();
2020
Application.Shutdown ();
2121
}
2222
}

Examples/ReactiveExample/TerminalScheduler.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ IDisposable PostOnMainLoop ()
2222
var cancellation = new CancellationDisposable ();
2323

2424
Application.Invoke (
25-
() =>
25+
(_) =>
2626
{
2727
if (!cancellation.Token.IsCancellationRequested)
2828
{

Examples/UICatalog/Resources/config.json

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@
8686
"Menu": {
8787
"Normal": {
8888
"Foreground": "Black",
89-
"Background": "WHite"
89+
"Background": "White"
9090
},
9191
"Focus": {
9292
"Foreground": "White",
@@ -136,17 +136,16 @@
136136
{
137137
"UI Catalog Theme": {
138138
"Window.DefaultShadow": "Transparent",
139+
"Button.DefaultShadow": "None",
139140
"CheckBox.DefaultHighlightStates": "In, Pressed, PressedOutside",
140141
"MessageBox.DefaultButtonAlignment": "Start",
141142
"StatusBar.DefaultSeparatorLineStyle": "Single",
142143
"Dialog.DefaultMinimumWidth": 80,
143-
"MessageBox.DefaultBorderStyle": "Dotted",
144144
"NerdFonts.Enable": false,
145145
"MessageBox.DefaultMinimumWidth": 0,
146146
"Window.DefaultBorderStyle": "Double",
147147
"Dialog.DefaultShadow": "Opaque",
148148
"Dialog.DefaultButtonAlignment": "Start",
149-
"Button.DefaultShadow": "Transparent",
150149
"FrameView.DefaultBorderStyle": "Double",
151150
"MessageBox.DefaultMinimumHeight": 0,
152151
"Button.DefaultHighlightStates": "In, Pressed",

Examples/UICatalog/Scenario.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -221,7 +221,7 @@ private void OnApplicationOnIteration (object? s, IterationEventArgs a)
221221

222222
private void OnApplicationSessionBegun (object? sender, SessionTokenEventArgs e)
223223
{
224-
SubscribeAllSubViews (Application.Top!);
224+
SubscribeAllSubViews (Application.Current!);
225225

226226
_demoKeys = GetDemoKeyStrokes ();
227227

@@ -241,7 +241,7 @@ private void OnApplicationSessionBegun (object? sender, SessionTokenEventArgs e)
241241

242242
return;
243243

244-
// Get a list of all subviews under Application.Top (and their subviews, etc.)
244+
// Get a list of all subviews under Application.Current (and their subviews, etc.)
245245
// and subscribe to their DrawComplete event
246246
void SubscribeAllSubViews (View view)
247247
{

Examples/UICatalog/Scenarios/AllViewsTester.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ public class AllViewsTester : Scenario
2828

2929
public override void Main ()
3030
{
31-
// Don't create a sub-win (Scenario.Win); just use Application.Top
31+
// Don't create a sub-win (Scenario.Win); just use Application.Current
3232
Application.Init ();
3333

3434
var app = new Window

Examples/UICatalog/Scenarios/AnimationScenario/AnimationScenario.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ private void OnWinOnInitialized (object? sender, EventArgs args)
9292
{
9393
// When updating from a Thread/Task always use Invoke
9494
Application.Invoke (
95-
() =>
95+
(_) =>
9696
{
9797
_imageView.NextFrame ();
9898
_imageView.SetNeedsDraw ();

Examples/UICatalog/Scenarios/AnsiRequestsScenario.cs

Lines changed: 61 additions & 58 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
1-
using System;
2-
using System.Collections.Generic;
3-
using System.Linq;
1+
#nullable enable
42
using System.Text;
53

64
namespace UICatalog.Scenarios;
@@ -9,16 +7,19 @@ namespace UICatalog.Scenarios;
97
[ScenarioCategory ("Tests")]
108
public sealed class AnsiEscapeSequenceRequests : Scenario
119
{
12-
private GraphView _graphView;
10+
private GraphView? _graphView;
1311

14-
private ScatterSeries _sentSeries;
15-
private ScatterSeries _answeredSeries;
12+
private ScatterSeries? _sentSeries;
13+
private ScatterSeries? _answeredSeries;
1614

1715
private readonly List<DateTime> _sends = new ();
1816

1917
private readonly object _lockAnswers = new object ();
2018
private readonly Dictionary<DateTime, string> _answers = new ();
21-
private Label _lblSummary;
19+
private Label? _lblSummary;
20+
21+
private object? _updateTimeoutToken;
22+
private object? _sendDarTimeoutToken;
2223

2324
public override void Main ()
2425
{
@@ -32,7 +33,7 @@ public override void Main ()
3233
CanFocus = true
3334
};
3435

35-
Tab single = new Tab ();
36+
Tab single = new ();
3637
single.DisplayText = "Single";
3738
single.View = BuildSingleTab ();
3839

@@ -57,6 +58,8 @@ public override void Main ()
5758
single.View.Dispose ();
5859
appWindow.Dispose ();
5960

61+
Application.RemoveTimeout (_updateTimeoutToken!);
62+
Application.RemoveTimeout (_sendDarTimeoutToken!);
6063
// Shutdown - Calling Application.Shutdown is required.
6164
Application.Shutdown ();
6265
}
@@ -70,7 +73,7 @@ private View BuildSingleTab ()
7073
CanFocus = true
7174
};
7275

73-
w.Padding.Thickness = new (1);
76+
w!.Padding!.Thickness = new (1);
7477

7578
var scrRequests = new List<string>
7679
{
@@ -103,7 +106,7 @@ private View BuildSingleTab ()
103106
}
104107

105108
var selAnsiEscapeSequenceRequestName = scrRequests [cbRequests.SelectedItem];
106-
AnsiEscapeSequence selAnsiEscapeSequenceRequest = null;
109+
AnsiEscapeSequence? selAnsiEscapeSequenceRequest = null;
107110

108111
switch (selAnsiEscapeSequenceRequestName)
109112
{
@@ -163,12 +166,12 @@ private View BuildSingleTab ()
163166
Value = string.IsNullOrEmpty (tfValue.Text) ? null : tfValue.Text
164167
};
165168

166-
Application.Driver.QueueAnsiRequest (
169+
Application.Driver?.QueueAnsiRequest (
167170
new ()
168171
{
169172
Request = ansiEscapeSequenceRequest.Request,
170173
Terminator = ansiEscapeSequenceRequest.Terminator,
171-
ResponseReceived = (s) => OnSuccess (s, tvResponse, tvError, tvValue, tvTerminator, lblSuccess),
174+
ResponseReceived = (s) => OnSuccess (s!, tvResponse, tvError, tvValue, tvTerminator, lblSuccess),
172175
Abandoned = () => OnFail (tvResponse, tvError, tvValue, tvTerminator, lblSuccess)
173176
});
174177
};
@@ -218,21 +221,21 @@ private View BuildBulkTab ()
218221
Width = Dim.Fill ()
219222
};
220223

221-
Application.AddTimeout (
222-
TimeSpan.FromMilliseconds (1000),
223-
() =>
224-
{
225-
lock (_lockAnswers)
226-
{
227-
UpdateGraph ();
224+
_updateTimeoutToken = Application.AddTimeout (
225+
TimeSpan.FromMilliseconds (1000),
226+
() =>
227+
{
228+
lock (_lockAnswers)
229+
{
230+
UpdateGraph ();
228231

229-
UpdateResponses ();
230-
}
232+
UpdateResponses ();
233+
}
231234

232235

233236

234-
return true;
235-
});
237+
return true;
238+
});
236239

237240
var tv = new TextView ()
238241
{
@@ -266,28 +269,28 @@ private View BuildBulkTab ()
266269

267270
int lastSendTime = Environment.TickCount;
268271
object lockObj = new object ();
269-
Application.AddTimeout (
270-
TimeSpan.FromMilliseconds (50),
271-
() =>
272-
{
273-
lock (lockObj)
274-
{
275-
if (cbDar.Value > 0)
276-
{
277-
int interval = 1000 / cbDar.Value; // Calculate the desired interval in milliseconds
278-
int currentTime = Environment.TickCount; // Current system time in milliseconds
279-
280-
// Check if the time elapsed since the last send is greater than the interval
281-
if (currentTime - lastSendTime >= interval)
282-
{
283-
SendDar (); // Send the request
284-
lastSendTime = currentTime; // Update the last send time
285-
}
286-
}
287-
}
288-
289-
return true;
290-
});
272+
_sendDarTimeoutToken = Application.AddTimeout (
273+
TimeSpan.FromMilliseconds (50),
274+
() =>
275+
{
276+
lock (lockObj)
277+
{
278+
if (cbDar.Value > 0)
279+
{
280+
int interval = 1000 / cbDar.Value; // Calculate the desired interval in milliseconds
281+
int currentTime = Environment.TickCount; // Current system time in milliseconds
282+
283+
// Check if the time elapsed since the last send is greater than the interval
284+
if (currentTime - lastSendTime >= interval)
285+
{
286+
SendDar (); // Send the request
287+
lastSendTime = currentTime; // Update the last send time
288+
}
289+
}
290+
}
291+
292+
return true;
293+
});
291294

292295

293296
_graphView = new GraphView ()
@@ -318,7 +321,7 @@ private View BuildBulkTab ()
318321
}
319322
private void UpdateResponses ()
320323
{
321-
_lblSummary.Text = GetSummary ();
324+
_lblSummary!.Text = GetSummary ();
322325
_lblSummary.SetNeedsDraw ();
323326
}
324327

@@ -340,8 +343,8 @@ private string GetSummary ()
340343
private void SetupGraph ()
341344
{
342345

343-
_graphView.Series.Add (_sentSeries = new ScatterSeries ());
344-
_graphView.Series.Add (_answeredSeries = new ScatterSeries ());
346+
_graphView!.Series.Add (_sentSeries = new ScatterSeries ());
347+
_graphView!.Series.Add (_answeredSeries = new ScatterSeries ());
345348

346349
_sentSeries.Fill = new GraphCellToRender (new Rune ('.'), new Attribute (ColorName16.BrightGreen, ColorName16.Black));
347350
_answeredSeries.Fill = new GraphCellToRender (new Rune ('.'), new Attribute (ColorName16.BrightRed, ColorName16.Black));
@@ -358,17 +361,17 @@ private void SetupGraph ()
358361

359362
private void UpdateGraph ()
360363
{
361-
_sentSeries.Points = _sends
364+
_sentSeries!.Points = _sends
362365
.GroupBy (ToSeconds)
363366
.Select (g => new PointF (g.Key, g.Count ()))
364367
.ToList ();
365368

366-
_answeredSeries.Points = _answers.Keys
369+
_answeredSeries!.Points = _answers.Keys
367370
.GroupBy (ToSeconds)
368371
.Select (g => new PointF (g.Key, g.Count ()))
369372
.ToList ();
370373
// _graphView.ScrollOffset = new PointF(,0);
371-
_graphView.SetNeedsDraw ();
374+
_graphView!.SetNeedsDraw ();
372375

373376
}
374377

@@ -379,13 +382,13 @@ private int ToSeconds (DateTime t)
379382

380383
private void SendDar ()
381384
{
382-
Application.Driver.QueueAnsiRequest (
383-
new ()
384-
{
385-
Request = EscSeqUtils.CSI_SendDeviceAttributes.Request,
386-
Terminator = EscSeqUtils.CSI_SendDeviceAttributes.Terminator,
387-
ResponseReceived = HandleResponse
388-
});
385+
Application.Driver?.QueueAnsiRequest (
386+
new ()
387+
{
388+
Request = EscSeqUtils.CSI_SendDeviceAttributes.Request,
389+
Terminator = EscSeqUtils.CSI_SendDeviceAttributes.Terminator,
390+
ResponseReceived = HandleResponse!
391+
});
389392
_sends.Add (DateTime.Now);
390393
}
391394

Examples/UICatalog/Scenarios/Bars.cs

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ public override void Main ()
2828
// QuitKey and it only sticks if changed after init
2929
private void App_Loaded (object sender, EventArgs e)
3030
{
31-
Application.Top!.Title = GetQuitKeyAndName ();
31+
Application.Current!.Title = GetQuitKeyAndName ();
3232

3333
ObservableCollection<string> eventSource = new ();
3434
ListView eventLog = new ListView ()
@@ -41,7 +41,7 @@ private void App_Loaded (object sender, EventArgs e)
4141
Source = new ListWrapper<string> (eventSource)
4242
};
4343
eventLog.Border!.Thickness = new (0, 1, 0, 0);
44-
Application.Top.Add (eventLog);
44+
Application.Current.Add (eventLog);
4545

4646
FrameView menuBarLikeExamples = new ()
4747
{
@@ -51,7 +51,7 @@ private void App_Loaded (object sender, EventArgs e)
5151
Width = Dim.Fill () - Dim.Width (eventLog),
5252
Height = Dim.Percent(33),
5353
};
54-
Application.Top.Add (menuBarLikeExamples);
54+
Application.Current.Add (menuBarLikeExamples);
5555

5656
Label label = new Label ()
5757
{
@@ -98,7 +98,7 @@ private void App_Loaded (object sender, EventArgs e)
9898
Width = Dim.Fill () - Dim.Width (eventLog),
9999
Height = Dim.Percent (33),
100100
};
101-
Application.Top.Add (menuLikeExamples);
101+
Application.Current.Add (menuLikeExamples);
102102

103103
label = new Label ()
104104
{
@@ -212,7 +212,7 @@ void MenuLikeExamplesMouseEvent (object _, MouseEventArgs e)
212212
Width = Dim.Width (menuLikeExamples),
213213
Height = Dim.Percent (33),
214214
};
215-
Application.Top.Add (statusBarLikeExamples);
215+
Application.Current.Add (statusBarLikeExamples);
216216

217217
label = new Label ()
218218
{
@@ -249,7 +249,7 @@ void MenuLikeExamplesMouseEvent (object _, MouseEventArgs e)
249249
ConfigStatusBar (bar);
250250
statusBarLikeExamples.Add (bar);
251251

252-
foreach (FrameView frameView in Application.Top.SubViews.Where (f => f is FrameView)!)
252+
foreach (FrameView frameView in Application.Current.SubViews.Where (f => f is FrameView)!)
253253
{
254254
foreach (Bar barView in frameView.SubViews.Where (b => b is Bar)!)
255255
{
@@ -269,8 +269,8 @@ void MenuLikeExamplesMouseEvent (object _, MouseEventArgs e)
269269

270270
//private void SetupContentMenu ()
271271
//{
272-
// Application.Top.Add (new Label { Text = "Right Click for Context Menu", X = Pos.Center (), Y = 4 });
273-
// Application.Top.MouseClick += ShowContextMenu;
272+
// Application.Current.Add (new Label { Text = "Right Click for Context Menu", X = Pos.Center (), Y = 4 });
273+
// Application.Current.MouseClick += ShowContextMenu;
274274
//}
275275

276276
//private void ShowContextMenu (object s, MouseEventEventArgs e)

0 commit comments

Comments
 (0)