Commit 1dc0279
committed
Fixed - was not working for variables in last line of heredoc.
It seems that heredoc() method excludes terminator line, so no need to pop()
https://metacpan.org/pod/PPI::Token::HereDoc#heredoc
added test for the bug, also added additional test to extract_variables (just
to make sure our regexp deals with newlines right)1 parent ebd3987 commit 1dc0279
File tree
3 files changed
+13
-1
lines changed- lib/Perl/Critic/Policy/ValuesAndExpressions
- t
- ValuesAndExpressions
3 files changed
+13
-1
lines changedLines changed: 0 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
413 | 413 | | |
414 | 414 | | |
415 | 415 | | |
416 | | - | |
417 | 416 | | |
418 | 417 | | |
419 | 418 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
18 | 22 | | |
19 | 23 | | |
20 | 24 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
104 | 104 | | |
105 | 105 | | |
106 | 106 | | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
107 | 116 | | |
108 | 117 | | |
109 | 118 | | |
| |||
0 commit comments