Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Saver and Searcher compatibility #25

Open
h-0-0 opened this issue Jan 17, 2024 · 0 comments
Open

Better Saver and Searcher compatibility #25

h-0-0 opened this issue Jan 17, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@h-0-0
Copy link
Owner

h-0-0 commented Jan 17, 2024

When Searcher has pointer to a Saver, ie. when we call 'searcher.check_existing_runs(saver)', the Searcher should keep the path stored in the attribute 'current_path' of the Saver up to date with the path corresponding to the last parameter configuration returned by the Searcher. That way the user can call '.get_current_path' to retrieve the path corresponding to the latest configuration given by the Searcher.

The above makes sense for existing Searchers (grid) and Savers (SaverCSV), however, this should really be implemented in a more abstract general way so that it will work for future Searchers and Savers.

To do this in a more general way there should just be some base method for all Searchers called 'update_state' that the searcher calls after each iteration.

@h-0-0 h-0-0 added the enhancement New feature or request label Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant