fix(tests): harden tickets and linear alias CI behavior

Author: roodboi

src/control-plane/extensions/tickets/tickets-git-channel.ts

@@ -1125,13 +1125,45 @@ async function runGit(opts: {
     stdout: "pipe",
     stderr: "pipe",
     stdin: "ignore",
+    env: {
+      ...process.env,
+      ...resolveTicketGitIdentityEnv(),
+    },
   });
   const stdout = await new Response(proc.stdout).text();
   const stderr = await new Response(proc.stderr).text();
   const exitCode = await proc.exited;
   return { ok: exitCode === 0, stdout, stderr };
 }
 
+function resolveTicketGitIdentityEnv(): Record<string, string> {
+  const authorName =
+    readOptionalEnv("GIT_AUTHOR_NAME") ??
+    readOptionalEnv("GIT_COMMITTER_NAME") ??
+    "hack tickets";
+  const authorEmail =
+    readOptionalEnv("GIT_AUTHOR_EMAIL") ??
+    readOptionalEnv("GIT_COMMITTER_EMAIL") ??
+    "tickets@hack.local";
+  const committerName = readOptionalEnv("GIT_COMMITTER_NAME") ?? authorName;
+  const committerEmail = readOptionalEnv("GIT_COMMITTER_EMAIL") ?? authorEmail;
+  return {
+    GIT_AUTHOR_NAME: authorName,
+    GIT_AUTHOR_EMAIL: authorEmail,
+    GIT_COMMITTER_NAME: committerName,
+    GIT_COMMITTER_EMAIL: committerEmail,
+  };
+}
+
+function readOptionalEnv(key: string): string | null {
+  const value = process.env[key];
+  if (typeof value !== "string") {
+    return null;
+  }
+  const trimmed = value.trim();
+  return trimmed.length > 0 ? trimmed : null;
+}
+
 function safeJsonParse(text: string): unknown {
   try {
     return JSON.parse(text);

tests/linear-command-alias.test.ts

@@ -1,6 +1,57 @@
-import { expect, test } from "bun:test";
+import { afterEach, beforeEach, expect, test } from "bun:test";
+import { mkdtemp, rm, writeFile } from "node:fs/promises";
+import { tmpdir } from "node:os";
 import { resolve } from "node:path";
 
+let tempDir: string | null = null;
+let tempGlobalConfigPath: string | null = null;
+let previousGlobalConfigPath: string | undefined;
+let previousHome: string | undefined;
+let previousLogger: string | undefined;
+let previousSetupSyncMode: string | undefined;
+
+beforeEach(async () => {
+  tempDir = await mkdtemp(resolve(tmpdir(), "hack-linear-alias-"));
+  tempGlobalConfigPath = resolve(tempDir, "hack.config.json");
+  previousGlobalConfigPath = process.env.HACK_GLOBAL_CONFIG_PATH;
+  previousHome = process.env.HOME;
+  previousLogger = process.env.HACK_LOGGER;
+  previousSetupSyncMode = process.env.HACK_SETUP_SYNC_MODE;
+  process.env.HACK_GLOBAL_CONFIG_PATH = tempGlobalConfigPath;
+  process.env.HOME = tempDir;
+  process.env.HACK_LOGGER = "console";
+  process.env.HACK_SETUP_SYNC_MODE = "off";
+  await writeFile(tempGlobalConfigPath, "{}\n");
+});
+
+afterEach(async () => {
+  if (tempDir) {
+    await rm(tempDir, { recursive: true, force: true });
+  }
+  tempDir = null;
+  tempGlobalConfigPath = null;
+  if (previousGlobalConfigPath === undefined) {
+    process.env.HACK_GLOBAL_CONFIG_PATH = undefined;
+  } else {
+    process.env.HACK_GLOBAL_CONFIG_PATH = previousGlobalConfigPath;
+  }
+  if (previousHome === undefined) {
+    process.env.HOME = undefined;
+  } else {
+    process.env.HOME = previousHome;
+  }
+  if (previousLogger === undefined) {
+    process.env.HACK_LOGGER = undefined;
+  } else {
+    process.env.HACK_LOGGER = previousLogger;
+  }
+  if (previousSetupSyncMode === undefined) {
+    process.env.HACK_SETUP_SYNC_MODE = undefined;
+  } else {
+    process.env.HACK_SETUP_SYNC_MODE = previousSetupSyncMode;
+  }
+});
+
 test("hack linear alias forwards extension options like --json", async () => {
   const proc = Bun.spawn(
     [
@@ -11,8 +62,14 @@ test("hack linear alias forwards extension options like --json", async () => {
       "--json",
     ],
     {
-      cwd: resolve(import.meta.dir, ".."),
-      env: process.env,
+      cwd: tempDir ?? resolve(import.meta.dir, ".."),
+      env: {
+        ...process.env,
+        HACK_GLOBAL_CONFIG_PATH: tempGlobalConfigPath ?? "",
+        HACK_LOGGER: "console",
+        HACK_SETUP_SYNC_MODE: "off",
+        HOME: tempDir ?? process.env.HOME ?? "",
+      },
       stdin: "ignore",
       stdout: "pipe",
       stderr: "pipe",