Merge pull request #40 from hack-dance/dimitri/fix-lifecycle-non-login-shell

fix(cli): avoid login shells for lifecycle commands

Author: roodboi

src/commands/project.ts

@@ -2141,9 +2141,9 @@ export function wrapLifecyclePersistentCommand(opts: {
     '  done < "$fifo" ) &',
     "reader_pid=$!",
     "if command -v python3 >/dev/null 2>&1; then",
-    '  python3 -c \'import os, sys; os.setsid(); os.execvp("sh", ["sh", "-lc", sys.argv[1]])\' "$HACK_LIFECYCLE_COMMAND" >"$fifo" 2>&1 &',
+    '  python3 -c \'import os, sys; os.setsid(); os.execvp("sh", ["sh", "-c", sys.argv[1]])\' "$HACK_LIFECYCLE_COMMAND" >"$fifo" 2>&1 &',
     "else",
-    '  sh -lc "$HACK_LIFECYCLE_COMMAND" >"$fifo" 2>&1 &',
+    '  sh -c "$HACK_LIFECYCLE_COMMAND" >"$fifo" 2>&1 &',
     "fi",
     "cmd_pid=$!",
     'wait "$cmd_pid"',

tests/project-lifecycle-processes.test.ts

@@ -137,6 +137,21 @@ test("wrapLifecyclePersistentCommand uses external kill for process-group cleanu
   );
 });
 
+test("wrapLifecyclePersistentCommand avoids login-shell execution", () => {
+  const script = wrapLifecyclePersistentCommand({
+    command: "bun run proxy",
+    logPath: "/tmp/event-agent.log",
+    serviceName: "proxy",
+  });
+
+  expect(script).toContain('os.execvp("sh", ["sh", "-c", sys.argv[1]])');
+  expect(script).toContain('sh -c "$HACK_LIFECYCLE_COMMAND" >"$fifo" 2>&1 &');
+  expect(script).not.toContain('os.execvp("sh", ["sh", "-lc", sys.argv[1]])');
+  expect(script).not.toContain(
+    'sh -lc "$HACK_LIFECYCLE_COMMAND" >"$fifo" 2>&1 &'
+  );
+});
+
 async function createLifecycleProjectDir(): Promise<string> {
   const root = await mkdtemp(join(tmpdir(), "hack-lifecycle-processes-"));
   tempDirs.add(root);