Skip to content

checking of GitHub repo while the submit design button #18

@0xmanidev

Description

@0xmanidev

I faced this while submitting I linked repo before adding image in readme and when I added image later it didn't recognize then I relinked but It didn't work because it is cache then I removed https:// part so it is refetch the repo and than it worked

process of recreating :

  • create a new project
  • link a repo without photo in readme
  • check submit design page for check list
  • then add photo in readme and again check the submit design checklist
  • try relinking without changing the link
  • same result in three cases
  • then try adding https:// or removing https:// to repo link it would work

solution:
recheck the photo while submitting the project for design and also every time the project is relinked

most probable cause:


// Check 3: README has photos (blocking)
if (readmeExists) {
  const hasPhoto = IMAGE_PATTERN.test(readmeContent!);
  checks.push({
    key: 'readme_has_photo',
    label: hasPhoto ? 'README has photos' : 'README photos missing',
    status: hasPhoto ? 'pass' : 'fail',
    detail: hasPhoto ? undefined : 'No images found in README - photos of your project are required to submit',
    blocking: true,
  });
}

path:stasis/lib/github-checks.ts

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions