Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Revamp email templates #801

Open
pierreTklein opened this issue Jan 21, 2022 · 2 comments · May be fixed by #775
Open

FR: Revamp email templates #801

pierreTklein opened this issue Jan 21, 2022 · 2 comments · May be fixed by #775

Comments

@pierreTklein
Copy link
Member

Each year, we have to fix bugs like sending the wrong links (discord, livesite, pdf etc.) to hackers. We also have to fix bugs where the email has the wrong confirm by / apply by dates.

This feature request is two-fold:

  • Add links to setting schema
  • Make the dates & link fields in emails parametrized, and provide the proper fields when constructing the email.
@brarsanmol
Copy link
Member

brarsanmol commented Jan 21, 2022

Hi Theo,

Exactly my thoughts! Just had a conversation with @logan-r about this today. We should be passing dates, names, and social links through handlebar templates.

Some major work has been done in the refactor to help enable this. I plan to add the social links to the settings model and allow them to modified through the dashboard. Same with the hackathon name so we don't have go through the codebase and edit all the instances of McHacks _.

@pierreTklein
Copy link
Member Author

Yep. That makes sense. And then we can also load those fields automatically to the frontend instead of storing it in the constants file.

@brarsanmol brarsanmol linked a pull request Jan 21, 2022 that will close this issue
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants