Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to react 17 #30

Closed
TomasSlama opened this issue Feb 3, 2021 · 0 comments
Closed

upgrade to react 17 #30

TomasSlama opened this issue Feb 3, 2021 · 0 comments

Comments

@TomasSlama
Copy link

Hi,

  events.forEach(event => {
      childRef.current.addEventListener(event, hydrate, {
        once: true,
        capture: true,
        passive: true
      });
      cleanupFns.push(() => {
        childRef.current.removeEventListener(event, hydrate, { capture: true });
      });
    });

this part of code needs to be refactored so we can upgrade to react 17

https://reactjs.org/blog/2020/08/10/react-v17-rc.html#potential-issues

@hadeeb hadeeb closed this as completed in 716e412 Mar 23, 2021
hadeeb pushed a commit that referenced this issue Mar 23, 2021
* Create an IntersectionObserver per component
* Add option to modify IntersectionObserver parameters
* Add option to override wrapper element
* Capture ref value in effects, closes #30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant