Feature Suggestion - Custom wrapper element

[tomkelsey]

Hi,

Great work with this project 👍

I wondered if it would be possible to include the ability to specify a custom wrapper element?

By default it could be a div (so it isn't a breaking change) but an additional wrapper attribute could be available to allow spans, articles, etc?

[hadeeb]

You can do that by passing a string to noWrapper prop.

https://github.com/hadeeb/react-lazy-hydration/releases/tag/v0.1.0

[tomkelsey]

Thanks - I’m not sure if I’m misunderstanding the code but I think as it is, after hydration, the custom wrapper element is ignored and just the children are rendered? Whilst if the default div wrapper is used, the div wrapper is rendered regardless of hydration status? For my use case I’m looking to keep the custom wrapper element both before and after hydration.

…

On Sat, 13 Nov 2021 at 07:11, Hadeeb Farhan ***@***.***> wrote: Closed #38 <#38>. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#38 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADNF7H2DWYYXYZEGQ7AM66DULYFRHANCNFSM5HMPYH2Q> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.