Convert Book ID's to MD5 to reduce collisions#274
Open
shaunbarlow wants to merge 7 commits into
Open
Conversation
added 2 commits
January 8, 2024 17:01
Keep fletcher hashes for the highlight refs. Retains backwards compatiblity with notes that store the old fletcher hashes, and will update them as new highlights are added
|
Hi Sr @shaunbarlow, is the hash used to track on which file new notes will be added? How does it work? As you mentioned, if it is to distinguish 2 books, why did the last way of Hashing collide with "The One Year Bible" TLB and "The One Year Bible TLB". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep fletcher hashes for the highlight refs.
Retains backwards compatibility with notes that store the old fletcher hashes, and will update them as new highlights are added
This is my attempt to fix this
Why
I have two books that have their highlights merged to to being assigned the same bookID with the current hash used. I want to be able to have them seperate, but otherwise cause as little disruption as possible.
For interest, the two books are "The One Year Bible TLB" and "How to Develop Your Personal Mission Statement" 🤷