[LoginNodes] Adapt check login nodes stopped script for multiple

Prior to this commit, the script only checks the first pool

Signed-off-by: Hanwen <[email protected]>

Author: hanwen-cluster

cookbooks/aws-parallelcluster-slurm/recipes/config/config_check_login_stopped_script.rb

@@ -18,11 +18,14 @@
   group 'root'
   mode '0700'
   variables(
-    target_group_name: lazy do
-      get_target_group_name(
-        node['cluster']['cluster_name'] || node['cluster']['stack_name'],
-        node['cluster']['config'].dig(:LoginNodes, :Pools, 0, :Name)
-      )
+    target_group_names: lazy do
+      # Generate a string that is the array representation in bash (e.g. "(item1, item2, item3)")
+      "(#{node['cluster']['config'].dig(:LoginNodes, :Pools).map do |pool_config|
+        get_target_group_name(
+          node['cluster']['cluster_name'] || node['cluster']['stack_name'],
+          pool_config['Name']
+        )
+      end.join(' ')})"
     end,
     region: node['cluster']['region']
   )

cookbooks/aws-parallelcluster-slurm/templates/default/slurm/head_node/check_login_nodes_stopped.sh.erb

@@ -8,38 +8,40 @@
 
 set -e
 
-TARGET_GROUP_NAME="<%= @target_group_name %>"
+TARGET_GROUP_NAMES=<%= @target_group_names %>
 REGION="<%= @region %>"
 
-# Get Target Group ARN
-target_group_arn=$(aws elbv2 describe-target-groups \
-    --names ${TARGET_GROUP_NAME} \
-    --query "TargetGroups[0].TargetGroupArn" \
-    --output text \
-    --region ${REGION})
-
-# Exit if Target Group is not found
-if [[ -n "${target_group_arn}" ]]; then
-    echo "TargetGroup ARN found: ${target_group_arn}"
-else
-    echo "No Target Group found for the specified Load Balancer ${load_balancer_arn}."
-    exit 1
-fi
-
-# Get the number of healthy and unhealthy targets
-target_healths=$(aws elbv2 describe-target-health \
-    --target-group-arn $target_group_arn \
-    --region ${REGION})
-
-healthy_count=$(echo $target_healths | jq -r '.TargetHealthDescriptions[] | select(.TargetHealth.State == "healthy") | .Target.Id' | wc -l)
-unhealthy_count=$(echo $target_healths | jq -r '.TargetHealthDescriptions[] | select(.TargetHealth.State != "healthy") | .Target.Id' | wc -l)
-
-# Check if there are running login nodes
-total_nodes=$((healthy_count + unhealthy_count))
-if [[ $total_nodes -gt 0 ]]; then
-    echo "Login nodes are running. Please stop them before updating the munge key."
-    exit 1
-fi
+for TARGET_GROUP_NAME in ${TARGET_GROUP_NAMES[@]}; do
+  # Get Target Group ARN
+  target_group_arn=$(aws elbv2 describe-target-groups \
+      --names ${TARGET_GROUP_NAME} \
+      --query "TargetGroups[0].TargetGroupArn" \
+      --output text \
+      --region ${REGION})
+
+  # Exit if Target Group is not found
+  if [[ -n "${target_group_arn}" ]]; then
+      echo "TargetGroup ARN found: ${target_group_arn}"
+  else
+      echo "No Target Group found for the specified Load Balancer ${load_balancer_arn}."
+      exit 1
+  fi
+
+  # Get the number of healthy and unhealthy targets
+  target_healths=$(aws elbv2 describe-target-health \
+      --target-group-arn $target_group_arn \
+      --region ${REGION})
+
+  healthy_count=$(echo $target_healths | jq -r '.TargetHealthDescriptions[] | select(.TargetHealth.State == "healthy") | .Target.Id' | wc -l)
+  unhealthy_count=$(echo $target_healths | jq -r '.TargetHealthDescriptions[] | select(.TargetHealth.State != "healthy") | .Target.Id' | wc -l)
+
+  # Check if there are running login nodes
+  total_nodes=$((healthy_count + unhealthy_count))
+  if [[ $total_nodes -gt 0 ]]; then
+      echo "Login nodes are running. Please stop them before updating the munge key."
+      exit 1
+  fi
+done
 
 echo "Login nodes are stopped."
 exit 0