Revert "[BE]: Enable RUFF TRY400 rule - log.exception (pytorch#153473)"

This reverts commit 4f4ecc5.

Reverted pytorch#153473 on behalf of https://github.com/jeanschmidt due to seems to have broken internal signals, @albanD may I count on you to help the author merge his PR? D74837988 ([comment](pytorch#153473 (comment)))

Author: pytorchmergebot

.flake8

@@ -16,9 +16,7 @@ ignore =
     # these ignores are from flake8-comprehensions; please fix!
     C407,
     # these ignores are from flake8-logging-format; please fix!
-    G100,G101,G200,
-    # G201 replaced by LOG400 in ruff
-    G201,
+    G100,G101,G200
     # these ignores are from flake8-simplify. please fix or ignore with commented reason
     SIM105,SIM108,SIM110,SIM111,SIM113,SIM114,SIM115,SIM116,SIM117,SIM118,SIM119,SIM12,
     # SIM104 is already covered by pyupgrade ruff

.github/scripts/runner_determinator.py

@@ -623,9 +623,9 @@ def main() -> None:
             is_canary,
         )
 
-    except Exception:
-        log.exception(
-            "Failed to get issue. Defaulting to Meta runners and no experiments."
+    except Exception as e:
+        log.error(
+            f"Failed to get issue. Defaulting to Meta runners and no experiments. Exception: {e}"
         )
 
     set_github_output(GH_OUTPUT_KEY_LABEL_TYPE, runner_label_prefix)

benchmarks/dynamo/common.py

@@ -1700,8 +1700,8 @@ def maybe_snapshot_memory(should_snapshot_memory, suffix):
                         f"{output_filename.rstrip('.csv')}_{suffix}.pickle",
                     )
                 )
-            except Exception:
-                log.exception("Failed to save memory snapshot")
+            except Exception as e:
+                log.error("Failed to save memory snapshot, %s", e)
 
             torch.cuda.memory._record_memory_history(enabled=None)
 
@@ -2742,7 +2742,7 @@ def minify_model(
         try:
             shutil.move("repro.py", f"{repro_dir}/{name}_repro.py")
         except OSError:
-            log.exception("Could not find repro script for model %s", name)
+            log.error("Could not find repro script for model %s", name)
         else:
             log.info(
                 "Repro script for model %s with minified graph saved to %s",

pyproject.toml

@@ -197,7 +197,6 @@ select = [
     "TC",
     "TRY002", # ban vanilla raise (todo fix NOQAs)
     "TRY203",
-    "TRY400", # use logging.exception
     "TRY401", # verbose-log-message
     "UP",
     "YTT",

tools/packaging/split_wheel.py

@@ -47,15 +47,11 @@ def requirements_installed() -> bool:
 
         return True
     except ImportError:
-        logger.error(  # noqa: TRY400
-            "Requirements not installed, run the following command to install:",
-            exc_info=False,
+        logger.error(
+            "Requirements not installed, run the following command to install:"
         )
-        logger.error(  # noqa: TRY400
-            "    > %s -m pip install -r %s/requirements.txt",
-            sys.executable,
-            ROOT_PATH,
-            exc_info=False,
+        logger.error(
+            "    > %s -m pip install -r %s/requirements.txt", sys.executable, ROOT_PATH
         )
         return False
 

torch/_dynamo/repro/after_aot.py

@@ -138,7 +138,7 @@ def debug_wrapper(
                         example_inputs,
                         compiler_name,
                     )
-                log.exception("CompilerError")
+                log.error("CompilerError")
             raise
 
         # We may run regular PyTorch compute that may trigger Dynamo, do NOT

torch/_dynamo/utils.py

@@ -2148,7 +2148,7 @@ def torchscript(model, example_inputs, verbose=False):
             if verbose:
                 log.exception("jit error")
             else:
-                log.error("Both torch.jit.trace and torch.jit.script failed")  # noqa: TRY400
+                log.error("Both torch.jit.trace and torch.jit.script failed")
     return None
 
 

torch/_guards.py

@@ -359,7 +359,7 @@ def create(self, builder: GuardBuilderBase):
         except Exception:
             log.exception("Error while creating guard:\n%s", str(self).rstrip())
             if self.stack:
-                log.error("Created at:\n%s", "".join(self.stack.format()[-4:]).rstrip())  # noqa: TRY400
+                log.error("Created at:\n%s", "".join(self.stack.format()[-4:]).rstrip())
             raise
 
     def is_specialized_nn_module(self):

torch/_inductor/codegen/cuda/cuda_env.py

@@ -22,8 +22,8 @@ def get_cuda_arch() -> Optional[str]:
             major, minor = torch.cuda.get_device_capability(0)
             return str(major * 10 + minor)
         return str(cuda_arch)
-    except Exception:
-        log.exception("Error getting cuda arch")
+    except Exception as e:
+        log.error("Error getting cuda arch: %s", e)
         return None
 
 
@@ -35,8 +35,8 @@ def get_cuda_version() -> Optional[str]:
         if cuda_version is None:
             cuda_version = torch.version.cuda
         return cuda_version
-    except Exception:
-        log.exception("Error getting cuda version")
+    except Exception as e:
+        log.error("Error getting cuda version: %s", e)
         return None
 
 

torch/_inductor/compile_fx.py

@@ -181,7 +181,7 @@ def _fx_compile_mode_default() -> tuple[FxCompileMode, bool]:
         import logging
 
         log = logging.getLogger(__name__)
-        log.error(  # noqa: TRY400
+        log.error(
             "Invalid value of %s for %s. Expected one of %s. Using default.",
             value,
             name,