🐛 fix(functions.rs): change parameter name from offer_id to order_id in do_cancel_offer function for clarity and consistency

🐛 fix(lib.rs): change parameter name from offer_id to order_id in cancel_offer function for clarity and consistency

Author: tlacloc

pallets/afloat/src/functions.rs

@@ -859,7 +859,11 @@ impl<T: Config> Pallet<T> {
     Ok(())
   }
 
-  pub fn do_cancel_offer(offer_id: StorageId) -> DispatchResult {
+  pub fn do_cancel_offer(order_id: StorageId) -> DispatchResult {
+	// ensure offer exists
+    ensure!(<AfloatOffers<T>>::contains_key(order_id), Error::<T>::OfferNotFound);
+    //get offer details
+    let offer = <AfloatOffers<T>>::get(order_id).unwrap();
 	Ok(())
   }
 }

pallets/afloat/src/lib.rs

@@ -402,11 +402,11 @@ pub mod pallet {
 
 	#[pallet::call_index(11)]
     #[pallet::weight(Weight::from_parts(10_000,0) + T::DbWeight::get().reads_writes(1,1))]
-    pub fn cancel_offer(origin: OriginFor<T>, offer_id: StorageId) -> DispatchResult {
+    pub fn cancel_offer(origin: OriginFor<T>, order_id: StorageId) -> DispatchResult {
       let who = ensure_signed(origin.clone())?;
       let is_admin_or_owner = Self::is_admin_or_owner(who.clone())?;
       ensure!(is_admin_or_owner, Error::<T>::Unauthorized);
-	  Self::do_cancel_offer(offer_id)
+	  Self::do_cancel_offer(order_id)
     }
   }
 }