New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix problematic error returns #29936

Open

cuishuang opened this issue Mar 15, 2025 · 1 comment

Labels

auth/userpass bug

Contributor

cuishuang commented Mar 15, 2025 •

edited

Loading

In https://github.com/hashicorp/vault/blob/main/builtin/credential/userpass/path_user_password.go#L86, err is returned, but err has already been checked at #L77, so it must be nil at this point.

Considering the context, it should be changed to return intErr instead.

cuishuang mentioned this issue

fix: Fix problematic error returns #29883

Open

6 tasks

Contributor

heatherezell commented Mar 26, 2025

Thank you for this! Let me get some engineering eyes on it.

heatherezell added auth/userpass bug labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment