Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid Boxed displayed when constructor present in let binding #1504

Open
isdiemer opened this issue Feb 7, 2025 · 3 comments · Fixed by #1524
Open

Invalid Boxed displayed when constructor present in let binding #1504

isdiemer opened this issue Feb 7, 2025 · 3 comments · Fixed by #1524
Assignees
@Negabinary
Labels
bug critical critical bug

Comments

@isdiemer
Copy link

isdiemer commented Feb 7, 2025

When a constructor pattern is in the "name" of a let binding, the display on hazel breaks. Minimal Reproduction:

Image
@isdiemer isdiemer changed the title Invalid Boxed displayed when Constructor present in let binding. Invalid Boxed displayed when constructor present in let binding Feb 7, 2025
@cyrus-
Copy link
Member

cyrus- commented Feb 10, 2025

This also happens with case when there is (or in this case, there should be) an error on the pattern:

Image

@cyrus- cyrus- added the bug label Feb 10, 2025
@cyrus-
Copy link
Member

cyrus- commented Feb 10, 2025

@Negabinary adding this to your stack

@cyrus- cyrus- moved this to Team Dynamics in Hazel Big Board Feb 10, 2025
@cyrus- cyrus- added the critical critical bug label Feb 10, 2025
@disconcision disconcision mentioned this issue Feb 11, 2025
Closed
Negabinary added a commit that referenced this issue Feb 14, 2025
@Negabinary
Fix #1504
3a91597
Negabinary added a commit that referenced this issue Feb 17, 2025
@Negabinary
Fix #1504
30ec64e
@Negabinary Negabinary linked a pull request Feb 17, 2025 that will close this issue
Unboxing fixes #1524
Merged
Negabinary added a commit that referenced this issue Feb 19, 2025
@Negabinary
Fix #1504
d233a2b
@github-project-automation github-project-automation bot moved this from Team Dynamics to Done in Hazel Big Board Feb 19, 2025
@cyrus-
Copy link
Member

cyrus- commented Feb 25, 2025 •
edited
Loading

Image

seems to still be happening @Negabinary

@cyrus- cyrus- reopened this Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Negabinary Negabinary

Labels
bug critical critical bug
Projects
Hazel Big Board
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unboxing fixes hazelgrove/hazel
3 participants
@cyrus- @Negabinary @isdiemer