Skip to content

Commit eb93eba

Browse files
authored
Merge pull request #8 from hazelops/feature/enable-profiling-and-logs
Add OpenTelemetry, reformat
2 parents 4c7b92e + 0c78e6a commit eb93eba

File tree

2 files changed

+53
-38
lines changed

2 files changed

+53
-38
lines changed

main.tf

Lines changed: 45 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -6,24 +6,24 @@ locals {
66
"DD_API_KEY",
77
])
88

9-
environment = merge(var.environment,
10-
{
11-
DD_APM_ENABLED = "true"
12-
DD_DOGSTATSD_NON_LOCAL_TRAFFIC = "true"
13-
DD_APM_NON_LOCAL_TRAFFIC = "true"
14-
DD_PROCESS_AGENT_ENABLED = "true"
15-
DD_TAGS = "env:${var.env} app:${var.app_name}"
16-
DD_TRACE_ANALYTICS_ENABLED = "true"
17-
DD_RUNTIME_METRICS_ENABLED = "true"
18-
DD_PROFILING_ENABLED = "true"
19-
DD_LOGS_INJECTION = "true"
9+
environment = merge(var.environment, {
10+
DD_APM_ENABLED = "true"
11+
DD_DOGSTATSD_NON_LOCAL_TRAFFIC = "true"
12+
DD_APM_NON_LOCAL_TRAFFIC = "true"
13+
DD_PROCESS_AGENT_ENABLED = "true"
14+
DD_TAGS = "env:${var.env} app:${var.app_name}"
15+
DD_TRACE_ANALYTICS_ENABLED = "true"
16+
DD_RUNTIME_METRICS_ENABLED = "true"
17+
DD_PROFILING_ENABLED = "true"
18+
DD_LOGS_INJECTION = "true"
19+
DD_OTLP_CONFIG_RECEIVER_PROTOCOLS_GRPC_ENDPOINT = var.opentelemetry_grpc_endpoint
20+
DD_OTLP_CONFIG_RECEIVER_PROTOCOLS_HTTP_ENDPOINT = var.opentelemetry_http_endpoint
2021

21-
// https://www.datadoghq.com/blog/monitor-aws-fargate/
22-
ECS_FARGATE = var.ecs_launch_type == "FARGATE" ? "true" : "false"
23-
},
24-
(var.ecs_launch_type == "EC2" && var.socket_apm_enabled_on_ec2) ? {
25-
DD_APM_RECEIVER_SOCKET = "/var/run/datadog.sock"
26-
DD_TRACE_AGENT_URL = "/var/run/datadog.sock"
22+
// https://www.datadoghq.com/blog/monitor-aws-fargate/
23+
ECS_FARGATE = var.ecs_launch_type == "FARGATE" ? "true" : "false"
24+
}, (var.ecs_launch_type == "EC2" && var.socket_apm_enabled_on_ec2) ? {
25+
DD_APM_RECEIVER_SOCKET = "/var/run/datadog.sock"
26+
DD_TRACE_AGENT_URL = "/var/run/datadog.sock"
2727
} : {}
2828
)
2929

@@ -34,13 +34,19 @@ locals {
3434
essential = true,
3535
resourceRequirements = var.resource_requirements
3636

37-
environment = [for k, v in local.environment : { name = k, value = v }]
37+
environment = [
38+
for k, v in local.environment : {
39+
name = k,
40+
value = v
41+
}
42+
]
3843

39-
secrets = [for param_name in local.global_secrets :
40-
{
41-
name = param_name
42-
valueFrom = "arn:aws:ssm:${data.aws_region.current.name}:${data.aws_caller_identity.current.account_id}:parameter/${var.env}/global/${param_name}"
43-
}
44+
secrets = [
45+
for param_name in local.global_secrets :
46+
{
47+
name = param_name
48+
valueFrom = "arn:aws:ssm:${data.aws_region.current.name}:${data.aws_caller_identity.current.account_id}:parameter/${var.env}/global/${param_name}"
49+
}
4450
]
4551

4652
mountPoints = var.ecs_launch_type == "FARGATE" ? [] : concat([
@@ -62,13 +68,14 @@ locals {
6268
},
6369

6470

65-
],
66-
var.socket_apm_enabled_on_ec2 ? [{
71+
], var.socket_apm_enabled_on_ec2 ? [
72+
{
6773
containerPath = "/var/run/datadog.sock"
6874
sourceVolume = "datadog-sock"
6975
// This is disabled temporarily to overcome json unmarshaling issue
7076
// readOnly = true
71-
}] : []
77+
}
78+
] : []
7279
)
7380

7481

@@ -77,7 +84,7 @@ locals {
7784
protocol = "udp",
7885
containerPort = 8125
7986
}
80-
] : [
87+
] : [
8188
{
8289
protocol = "tcp",
8390
containerPort = 8126
@@ -115,17 +122,17 @@ locals {
115122
host_path = "/cgroup/"
116123
}
117124

118-
],
119-
var.socket_apm_enabled_on_ec2 ? [
120-
{
121-
name = "datadog-sock"
122-
host_path = "/var/run/datadog.sock"
123-
mount_point = {
124-
"sourceVolume" = "datadog-sock"
125-
"containerPath" = "/var/run/datadog.sock"
126-
"readOnly" = null
127-
}
128-
}] : []
125+
], var.socket_apm_enabled_on_ec2 ? [
126+
{
127+
name = "datadog-sock"
128+
host_path = "/var/run/datadog.sock"
129+
mount_point = {
130+
"sourceVolume" = "datadog-sock"
131+
"containerPath" = "/var/run/datadog.sock"
132+
"readOnly" = null
133+
}
134+
}
135+
] : []
129136
)
130137

131138
}

variables.tf

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,14 @@ variable "socket_apm_enabled_on_ec2" {
5050
default = false
5151
}
5252

53+
variable "opentelemetry_grpc_endpoint" {
54+
default = "0.0.0.0:4317"
55+
}
56+
57+
variable "opentelemetry_http_endpoint" {
58+
default = "0.0.0.0:4318"
59+
}
60+
5361
variable "enabled" {
5462
default = true
5563
}

0 commit comments

Comments
 (0)