Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make build process working on Windows machines #3560

Open
aichukanov opened this issue Aug 5, 2023 · 9 comments
Open

Make build process working on Windows machines #3560

aichukanov opened this issue Aug 5, 2023 · 9 comments
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@aichukanov
Copy link

aichukanov commented Aug 5, 2023

I've got a fail on rush build and don't know why, because of encoding problem in powershell/cmd/bash (Windows 10)

image

@aichukanov
Copy link
Author

Found that It's because there is no rm on Windows. Removed using rm -rf from commands as a workaround.

@haiodo
Copy link
Member

haiodo commented Aug 6, 2023

@aichukanov I think nobody was build it on windows.

@aplatoff aplatoff changed the title Encoding problem on build fail Make build process working on Windows machines Aug 28, 2023
@aplatoff aplatoff added good first issue Good for newcomers help wanted Extra attention is needed labels Aug 28, 2023
@Frumcheg
Copy link

@aichukanov Hi! I manage to run project on my windows machine using WSL. You can find install guide here.

@CyberPanCake3000
Copy link

Hi!
@aichukanov, I was struggling with building the project on windows with WSL too but found out that visual studio reformatted shell files and files from /common/scripts directory (they are important for setting up the project) from LF to CRLF 😞
I hope it will help you and other devs 🌟

@aeswibon
Copy link
Contributor

aeswibon commented Mar 29, 2024

I faced multiple errors while trying to bundle the packages with rush bundle. I just switched to Git bash on Windows and replaced mkdir -p with rm -rf bundle && mkdir so that it would first delete the old dir and then create the new dir. Moreover, still facing some issues, like:

--[ FAILURE: @hcengineering/pod-account (bundle) ]-----------[ 3.03 seconds ]--
--minify was unexpected at this time.

--[ FAILURE: @hcengineering/pod-front (bundle) ]-------------[ 3.38 seconds ]--
--bundle was unexpected at this time.

--[ FAILURE: @hcengineering/pod-server (bundle) ]------------[ 3.52 seconds ]--
--define:process.env.GIT_REVISION was unexpected at this time.

--[ FAILURE: @hcengineering/tool (bundle) ]------------------[ 3.28 seconds ]--
--define:process.env.GIT_REVISION was unexpected at this time.

@Fatema-Nawrin
Copy link

@aeswibon I am facing the same issues. Did you solve it?

@aeswibon
Copy link
Contributor

Nope, I tried to fix the script but is not working. Currently shifted to WSL to run the project.

This was referenced Jul 15, 2024
@FesterCluck
Copy link

Is this actually working or are folks still stuck in WSL? I'm about to clone and give this a shot. If it's still broken, happy to pick up. Otherwise, recommend close.

@stan-kondrat
Copy link

I investigated this bug and found potential solutions:

  1. Use cross-spawn in the following files to improve cross-platform compatibility:

    • platform-rig/bin/compile.js
    • platform-rig/bin/do-svelte-check.js
    • templates/apply.js
  2. Install Bash on Windows and add the following to common/config/rush/.npmrc:

    script-shell=bash
    

    However, this approach has a blocker since rush doesn't support the script-shell config (while npm run does). I've created an issue in the Rush repository to address this limitation: microsoft/rushstack#5076.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

10 participants