Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cached downsized images not removed from the storage #4187

Open
aonnikov opened this issue Dec 13, 2023 — with Huly for GitHub · 3 comments
Open

Cached downsized images not removed from the storage #4187

aonnikov opened this issue Dec 13, 2023 — with Huly for GitHub · 3 comments

Comments

@aonnikov Huly for GitHub
Copy link
Member

aonnikov commented Dec 13, 2023 •
edited by huly-github-staging bot
Loading

No description provided.

@haiodo
Copy link
Member

haiodo commented Dec 13, 2023

As I remember it. was a trigger to remove them.

@aonnikov Huly for GitHub
Copy link
Member Author

aonnikov commented Dec 13, 2023 •
edited
Loading

does not work as expected, I’ve just tried - have an image and two small images (64px and 256px), after the fullsize image is deleted, I still can see small images in minio.

@aonnikov Huly for GitHub
Copy link
Member Author

Prefixes work only when a proper delimiter is used, for JS minio client delimiter is hardcoded to /
https://github.com/minio/minio-js/blob/b109cdb0ce228b134620433fe3d8f41ac9be2d4d/src/minio.js#L365

But if we start using / as a delimiter, we won’t be able to access the original image - the prefix is a folder, and can’t be file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@haiodo @aonnikov