Merge pull request #79 from jyoung488/error-message

Fix access to error message

Author: radhack

lib/hello_sign/client.rb

@@ -178,10 +178,10 @@ def make_connection options
     def validate(response)
       if response.status >= 400
         error_class = ERRORS[response.status] || HelloSign::Error::UnknownError
-        error = error_class.new
-        error.response_status = response.status
-        error.response_body = response.body
-        error.request_uri = response.to_hash[:url].to_s
+        error = error_class.new(response.status, response.body, response.to_hash[:url].to_s)
+        # error.response_status = response.status
+        # error.response_body = response.body
+        # error.request_uri = response.to_hash[:url].to_s
         raise error
       end
     end

lib/hello_sign/error.rb

@@ -26,19 +26,20 @@ module HelloSign
   module Error
     # Custom error class for rescuing from all HelloSign errors.
     class Error < StandardError;
-      attr_accessor :request_uri
-      attr_accessor :response_body
-      attr_accessor :response_status
+      attr_accessor :request_uri, :response_body, :response_status
 
-      def initialize(message = nil)
-        super(message || human_readable_message)
+      def initialize(response_status, response_body = nil, request_uri)
+        @request_uri = request_uri
+        @response_body = response_body
+        @response_status = response_status
+        super(human_readable_message)
       end
 
       private
       def human_readable_message
-        "Server responded with code #{response_status}\n" \
-          "Request URI: #{request_uri}\n"\
-          "Message: #{response_body}"
+        "Server responded with code #{@response_status}\n" \
+          "Request URI: #{@request_uri}\n"\
+          "Message: #{@response_body}"
       end
     end
 

lib/hello_sign/version.rb

@@ -23,5 +23,5 @@
 #
 
 module HelloSign
-  VERSION = '3.6.1'
+  VERSION = '3.6.2'
 end

spec/hello_sign/error_spec.rb

@@ -2,9 +2,9 @@
 
 describe HelloSign::Error do
   # another test to prove backwards compatibility
-  describe 'custom error message' do
-    subject { HelloSign::Error::Error.new('Foo').message }
-    it { is_expected.to eql('Foo') }
+  it 'raises an error with any message' do
+    error = HelloSign::Error::Error.new(404, 'test error message', 'http://www.test.com')
+    expect(error).to be_instance_of(HelloSign::Error::Error)
   end
-end
 
+end