Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dependencies of the lib from devDependencies to peerDependencies #35

Open
jhomarolo opened this issue Jun 7, 2022 · 0 comments
Open

Add dependencies of the lib from devDependencies to peerDependencies #35

jhomarolo opened this issue Jun 7, 2022 · 0 comments
Labels
dependencies Pull requests that update a dependency file ready-to-work Item is ready to work on it severity-nice-to-have Item is nice to have

Comments

@jhomarolo
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Some dependencies of the lib like ( gotu etc) are listed as devDependencies, but are a peerDependencies as well (https://nodejs.org/es/blog/npm/peer-dependencies/) and should be added in this section too

Describe the solution you'd like
Like herbs2knex(https://github.com/herbsjs/herbs2knex/blob/master/package.json) the lib should list the peer dependency
@jhomarolo jhomarolo added enhancement New feature or request dependencies Pull requests that update a dependency file severity-nice-to-have Item is nice to have ready-to-work Item is ready to work on it and removed enhancement New feature or request labels Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file ready-to-work Item is ready to work on it severity-nice-to-have Item is nice to have
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jhomarolo