Skip to content

Random bot fixes #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dzbarsky wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Random bot fixes #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions examples/mysql/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,8 @@ itest_service(
"127.0.0.1",
"--port",
"$${PORT}",
"--socket",
"$${SOCKET_DIR}/mysql.sock",
Comment on lines +70 to +71

@chatgpt-codex-connector chatgpt-codex-connector Bot Mar 19, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Give the port MySQL example its own socket filename

These new args reuse the same mysql.sock path as //examples/mysql:mysql_listening_on_socket, but SOCKET_DIR is created once per svcinit run and then substituted into every service spec (cmd/svcinit/main.go). That means a service_test or itest_service_group that starts both public MySQL examples will now launch two mysqld processes against the same Unix socket path, so one of them fails to start even though their TCP ports are different.

Useful? React with 👍 / 👎.

],
autoassign_port = True,
exe = ":with_migrations",
Expand Down
8 changes: 8 additions & 0 deletions examples/redis/BUILD.redis
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
load("@rules_shell//shell:sh_binary.bzl", "sh_binary")

REDIS_COPTS = [
# Redis intentionally performs unaligned 64-bit loads in siphash.c.
# The Zig toolchain enables alignment UB traps in fastbuild, which causes
# the server to crash on arm64 before it becomes healthy.
"-fno-sanitize=alignment",
]

cc_library(
name = "linenoise",
srcs = glob([
Expand Down Expand Up @@ -64,6 +71,7 @@ cc_library(
"src/redis-cli.c",
],
) + ["release.h"],
copts = REDIS_COPTS,
textual_hdrs = select({
"@platforms//os:linux": ["src/ae_epoll.c"],
"@platforms//os:osx": ["src/ae_kqueue.c", "src/ae_select.c"],
Expand Down
Loading