test(cli): check whether Chrome outlives a killed parent on each OS

Author: miguel-heygen

.github/checkfast/pipekill.mjs

@@ -0,0 +1,42 @@
+// Does a Chrome launched by a node parent survive SIGKILL of that parent? pipe-only vs pipe+port, 3 trials each.
+import { spawn } from "node:child_process";
+import { mkdtempSync } from "node:fs";
+import { tmpdir } from "node:os";
+import { join } from "node:path";
+import { createRequire } from "node:module";
+
+const chrome = process.argv[2];
+if (process.argv[3] === "child") {
+  const puppeteer = createRequire(join(process.cwd(), "packages/cli/package.json"))("puppeteer-core");
+  const args = process.argv[4] === "port" ? ["--remote-debugging-port=0"] : [];
+  const b = await puppeteer.launch({ executablePath: chrome, pipe: true, headless: true,
+    userDataDir: mkdtempSync(join(tmpdir(), "cf-pipekill-")), args });
+  const p = await b.newPage();
+  await p.goto("about:blank");
+  console.log(`PID ${b.process().pid}`);
+  setInterval(() => {}, 1000);
+} else {
+  const alive = (pid) => { try { process.kill(pid, 0); return true; } catch { return false; } };
+  const wait = (ms) => new Promise((r) => setTimeout(r, ms));
+  let failures = 0;
+  for (const mode of ["pipe", "port"]) {
+    for (let t = 1; t <= 3; t++) {
+      const child = spawn(process.execPath, [process.argv[1], chrome, "child", mode], { stdio: ["ignore", "pipe", "inherit"] });
+      const pid = await new Promise((resolve) => {
+        let out = "";
+        child.stdout.on("data", (d) => { out += d; const m = out.match(/PID (\d+)/); if (m) resolve(Number(m[1])); });
+      });
+      child.kill("SIGKILL");
+      await wait(3000);
+      const survived = alive(pid);
+      console.log(`${process.platform} ${mode} trial${t} chrome ${pid} ${survived ? "ALIVE" : "exited"}`);
+      if (survived) {
+        if (mode === "pipe") failures++;
+        if (process.platform === "win32") spawn("taskkill", ["/PID", String(pid), "/T", "/F"]);
+        else process.kill(pid, "SIGKILL");
+        await wait(1000);
+      }
+    }
+  }
+  process.exit(failures ? 1 : 0);
+}

.github/workflows/checkfast-timing.yml

@@ -14,7 +14,7 @@ jobs:
       matrix:
         include:
           - { os: windows-latest, defender: on }
-          - { os: windows-latest, defender: off }
+          - { os: macos-latest, defender: none }
           - { os: ubuntu-latest, defender: none }
     env:
       HYPERFRAMES_NO_TELEMETRY: "1"
@@ -34,6 +34,9 @@ jobs:
       - name: Install FFmpeg (Linux)
         if: runner.os == 'Linux'
         run: sudo apt-get update -qq && sudo apt-get install -y -qq ffmpeg
+      - name: Install FFmpeg (macOS)
+        if: runner.os == 'macOS'
+        run: brew install ffmpeg
       - name: Set FFMPEG_BIN for bun install
         if: runner.os == 'Windows'
         shell: pwsh
@@ -56,9 +59,11 @@ jobs:
           bun run --filter @hyperframes/core build
           bun run --filter '@hyperframes/{engine,producer,player,studio}' build
           bun run --filter @hyperframes/cli build
-      - name: Time check
+      - name: Chrome survives a killed parent?
         shell: bash
-        run: bash .github/checkfast/run.sh
+        run: |
+          node packages/cli/bin/hyperframes.mjs browser ensure > /dev/null 2>&1
+          node .github/checkfast/pipekill.mjs "$(node packages/cli/bin/hyperframes.mjs browser path)"
       - uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4
         if: always()
         with: