libvoikko installation instructions don't work

[bowersd]

On https://github.com/hfst/hfst-ospell/wiki/UseAsSpellChecker you provide instructions for installing libvoikko. Setting aside that the libvoikko link does not go to http://voikko.puimula.org/sources.html and that the instructions you give do not tell users to cd into the libvoikko... directory after untarring it, running make (on my machine at least) throws an error and fails:

Using libvoikko version 3.4.1:
-Werror -pedantic -MT spellchecker/SpellerFactory.lo -MD -MP -MF spellchecker/.deps/SpellerFactory.Tpo -c spellchecker/SpellerFactory.cpp -fPIC -DPIC -o spellchecker/.libs/SpellerFactory.o
In file included from /usr/include/ospell.h:27:0,
from ./spellchecker/HfstSpeller.hpp:26,
from spellchecker/SpellerFactory.cpp:26:
/usr/include/hfst-ol.h:39:9: error: 'uint16_t' does not name a type
typedef uint16_t SymbolNumber;
^

Trying with libvoikko version 4.1.1:
libtool: compile: g++ -DHAVE_CONFIG_H -I. -I.. -g -O2 -std=c++11 -fvisibility=hidden -Wall -Werror -pedantic -MT morphology/AnalyzerFactory.lo -MD -MP -MF morphology/.deps/AnalyzerFactory.Tpo -c morphology/AnalyzerFactory.cpp -fPIC -DPIC -o morphology/.libs/AnalyzerFactory.o
In file included from morphology/AnalyzerFactory.cpp:43:0:
./morphology/HfstAnalyzer.hpp:52:3: error: ‘hfst_ol’ does not name a type
hfst_ol::Transducer *t;
^

I know that libvoikko isn't strictly your gig, but if you know of a way to get around these installation problems, you should share them with your users. :)

[bowersd]

I'm on Ubuntu (xenial)

[flammie]

I think there is ongoing work to get hfst-enabled voikko into debian and ubuntu, maybe you can find a version of these in Tino Didriksen's packages, some informations are in the apertium wiki: http://wiki.apertium.org/wiki/Install_Apertium_core_using_packaging

[bowersd]

Tino Didriksen's apertium core packages did the trick!

[bowersd]

It seems to not work again, at least it worked once...

[blackPantherOS]

We have same problem on blackPanther OS 17.1 64bit, Gcc-8.2.1

libtool: compile:  g++ -DHAVE_CONFIG_H -I. -I.. -O2 -g -pipe -Wformat -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fstack-protector --param=ssp-buffer-size=4 -std=c++11 -fvisibility=hidden -Wall -Werror -pedantic -MT morphology/AnalyzerFactory.lo -MD -MP -MF morphology/.deps/AnalyzerFactory.Tpo -c morphology/AnalyzerFactory.cpp  -fPIC -DPIC -o morphology/.libs/AnalyzerFactory.o
In file included from morphology/AnalyzerFactory.cpp:43:
./morphology/HfstAnalyzer.hpp:52:3: error: 'hfst_ol' does not name a type; did you mean 'wcstol'?
   hfst_ol::Transducer *t;
   ^~~~~~~
   wcstol
make[3]: *** [Makefile:1466: morphology/AnalyzerFactory.lo] Error 1
make[3]: Leaving directory '/usr/src/RPM/BUILD/libvoikko-4.1.1/src'
make[2]: *** [Makefile:866: all] Error 2
make[2]: Leaving directory '/usr/src/RPM/BUILD/libvoikko-4.1.1/src'
make[1]: *** [Makefile:435: all-recursive] Error 1
make[1]: Leaving directory '/usr/src/RPM/BUILD/libvoikko-4.1.1'
make: *** [Makefile:367: all] Error 2
error: Bad exit status from /var/tmp/rpm-tmp.BihlDz (%build)

[flammie]

current hfst-ospell is only compatible with the newest libvoikko, the relevant change is here: voikko/corevoikko@c516a6e