Skip to content
This repository was archived by the owner on Sep 1, 2023. It is now read-only.

Commit 289c56e

Browse files
committed
Add new FIXMEs for 4.20
1 parent 18b40c1 commit 289c56e

File tree

2 files changed

+7
-0
lines changed

2 files changed

+7
-0
lines changed

src/TypeSpec/__Private/ShapeSpec.hack

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ final class ShapeSpec extends TypeSpec<shape()> {
4242
TypeCoercionException::withValue($this->getTrace(), 'shape', $value);
4343
}
4444

45+
/* HH_IGNORE_ERROR[4323] unsafe generics (4.20+) */
4546
$value = dict(/* HH_FIXME[4110] */$value);
4647
$out = dict[];
4748
foreach ($this->inners as $key => $spec) {

src/TypeSpec/__Private/from_type_structure.hack

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -129,6 +129,7 @@ function from_type_structure<T>(TypeStructure<T> $ts): TypeSpec<T> {
129129
/* HH_IGNORE_ERROR[4110] unsafe generics */
130130
return new VectorSpec(
131131
/* HH_IGNORE_ERROR[4110] unsafe generics (4.7+) */
132+
/* HH_IGNORE_ERROR[4323] unsafe generics (4.20+) */
132133
$classname,
133134
from_type_structure(
134135
TypeAssert\not_null($ts['generic_types'] ?? null)[0],
@@ -140,6 +141,7 @@ function from_type_structure<T>(TypeStructure<T> $ts): TypeSpec<T> {
140141
/* HH_IGNORE_ERROR[4110] unsafe generics */
141142
return new MapSpec(
142143
/* HH_IGNORE_ERROR[4110] unsafe generics (4.7+) */
144+
/* HH_IGNORE_ERROR[4323] unsafe generics (4.20+) */
143145
$classname,
144146
from_type_structure(
145147
TypeAssert\not_null($ts['generic_types'] ?? null)[0],
@@ -154,6 +156,7 @@ function from_type_structure<T>(TypeStructure<T> $ts): TypeSpec<T> {
154156
/* HH_IGNORE_ERROR[4110] unsafe generics */
155157
return new SetSpec(
156158
/* HH_IGNORE_ERROR[4110] unsafe generics (4.7+) */
159+
/* HH_IGNORE_ERROR[4323] unsafe generics (4.20+) */
157160
$classname,
158161
from_type_structure(
159162
TypeAssert\not_null($ts['generic_types'] ?? null)[0],
@@ -170,6 +173,7 @@ function from_type_structure<T>(TypeStructure<T> $ts): TypeSpec<T> {
170173
/* HH_IGNORE_ERROR[4110] unsafe generics */
171174
return new KeyedTraversableSpec(
172175
/* HH_IGNORE_ERROR[4110] unsafe generics (4.7+) */
176+
/* HH_IGNORE_ERROR[4323] unsafe generics (4.20+) */
173177
$classname,
174178
from_type_structure(
175179
TypeAssert\not_null($ts['generic_types'] ?? null)[0],
@@ -183,6 +187,7 @@ function from_type_structure<T>(TypeStructure<T> $ts): TypeSpec<T> {
183187
/* HH_IGNORE_ERROR[4110] unsafe generics */
184188
return new TraversableSpec(
185189
/* HH_IGNORE_ERROR[4110] unsafe generics (4.7+) */
190+
/* HH_IGNORE_ERROR[4323] unsafe generics (4.20+) */
186191
$classname,
187192
from_type_structure(
188193
TypeAssert\not_null($ts['generic_types'] ?? null)[0],
@@ -196,6 +201,7 @@ function from_type_structure<T>(TypeStructure<T> $ts): TypeSpec<T> {
196201
case TypeStructureKind::OF_ENUM:
197202
$enum = TypeAssert\not_null($ts['classname']);
198203
/* HH_IGNORE_ERROR[4110] */
204+
/* HH_IGNORE_ERROR[4323] unsafe generics (4.20+) */
199205
return new EnumSpec($enum);
200206
case TypeStructureKind::OF_UNRESOLVED:
201207
throw new UnsupportedTypeException('OF_UNRESOLVED');

0 commit comments

Comments
 (0)