Replace non-refining instaoce $what with non-refining is_a()

fredemmott · fredemmott · commit 2b12b45aef9f · 2019-07-18T11:26:13.000-07:00
diff --git a/src/TypeSpec/__Private/InstanceOfSpec.hack b/src/TypeSpec/__Private/InstanceOfSpec.hack
@@ -21,7 +21,7 @@ final class InstanceOfSpec<T> extends TypeSpec<T> {
 
   <<__Override>>
   public function assertType(mixed $value): T {
-    if ($value instanceof $this->what) {
+    if (\is_a($value, $this->what)) {
       /* HH_IGNORE_ERROR[4110] unsafe for generics */
       return $value;
     }

Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ final class InstanceOfSpec<T> extends TypeSpec<T> {`
`21`	`21`
`22`	`22`	`<<__Override>>`
`23`	`23`	`public function assertType(mixed $value): T {`
`24`		`- if ($value instanceof $this->what) {`
	`24`	`+ if (\is_a($value, $this->what)) {`
`25`	`25`	`/* HH_IGNORE_ERROR[4110] unsafe for generics */`
`26`	`26`	`return $value;`
`27`	`27`	`}`