Skip to content

Remove shard realm encoding in long zero addresses #19181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
15 tasks
lukelee-sl opened this issue May 13, 2025 · 0 comments · May be fixed by #19349
Open
15 tasks

Remove shard realm encoding in long zero addresses #19181

lukelee-sl opened this issue May 13, 2025 · 0 comments · May be fixed by #19349
Assignees
Labels
Hedera Smart Contract Service Issues related to the Hedera Smart Contract Service. Team Promoted

Comments

@lukelee-sl
Copy link
Contributor

Background

Currently, long zero addresses encode the shard and realm values. After discussion, this behaviour needs to be reverted as it serves no purpose and possibly causes unnecessary complications.

Acceptance Criteria

  1. Ensure that shard/realm do not get encoded into long zero addresses
  2. Test that addresses with where the first 12 bytes are not zero are treated as normal EVM addresses verses long zero.
  3. Fix HAPI tests that have been altered to use long zero addresses with encoded shards and realms

Dependencies

No response

Definition of Ready (DoR) Checklist

  • Clear acceptance criteria
  • Clear and detailed description
  • Dependencies identified
  • Links to documentation
  • Should be completable in 2-3 Days
  • Initial draft of Low-level design document
  • At least high level test plan
  • Groomed/Estimated

Definition of Done (DoD) Checklist

  • Acceptance Criteria complete
  • No Codacy issues greater than minor (in new code)
  • JavaDocs updated/created
  • Code commented
  • Unit tests created/updated
  • 80% test code coverage (in new code)
  • Happy Path and major negative cases in HAPI tests as applicable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hedera Smart Contract Service Issues related to the Hedera Smart Contract Service. Team Promoted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants