fix: Type hints for topic-related transactions (#599)

Signed-off-by: Manish Dait <[email protected]>

Author: manishdait

CHANGELOG.md

@@ -48,6 +48,7 @@ This changelog is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.
 
 - Add type hints to `setup_client()` and `create_new_account()` functions in `examples/account_create.py` (#418)
 - Added explicit read and write permissions to test.yml
+- Type hinting for `Topic` related transactions.
 
 ### Removed
 - Remove deprecated camelCase alias support and `_DeprecatedAliasesMixin`; SDK now only exposes snake_case attributes for `NftId`, `TokenInfo`, and `TransactionReceipt`. (Issue #428)

src/hiero_sdk_python/consensus/topic_delete_transaction.py

@@ -7,11 +7,11 @@
 """
 
 from typing import Optional
+from hiero_sdk_python.consensus.topic_id import TopicId
 from hiero_sdk_python.transaction.transaction import Transaction
 from hiero_sdk_python.hapi.services import (
     consensus_delete_topic_pb2,
-    transaction_pb2,
-    basic_types_pb2
+    transaction_pb2
 )
 from hiero_sdk_python.hapi.services.schedulable_transaction_body_pb2 import (
     SchedulableTransactionBody,
@@ -27,12 +27,12 @@ class TopicDeleteTransaction(Transaction):
 
     """
 
-    def __init__(self, topic_id: Optional[basic_types_pb2.TopicID] = None) -> None:
+    def __init__(self, topic_id: Optional[TopicId] = None) -> None:
         super().__init__()
-        self.topic_id: Optional[basic_types_pb2.TopicID] = topic_id
+        self.topic_id: Optional[TopicId] = topic_id
         self.transaction_fee: int = 10_000_000
 
-    def set_topic_id(self, topic_id: basic_types_pb2.TopicID ) -> "TopicDeleteTransaction":
+    def set_topic_id(self, topic_id:TopicId ) -> "TopicDeleteTransaction":
         """
         Sets the topic ID for the transaction.
         

src/hiero_sdk_python/consensus/topic_message_submit_transaction.py

@@ -4,9 +4,10 @@
 """
 from typing import Optional
 
+from hiero_sdk_python.consensus.topic_id import TopicId
 from hiero_sdk_python.transaction.transaction import Transaction
 from hiero_sdk_python.transaction.custom_fee_limit import CustomFeeLimit
-from hiero_sdk_python.hapi.services import consensus_submit_message_pb2, basic_types_pb2
+from hiero_sdk_python.hapi.services import consensus_submit_message_pb2
 from hiero_sdk_python.hapi.services import transaction_pb2
 from hiero_sdk_python.hapi.services.schedulable_transaction_body_pb2 import (
     SchedulableTransactionBody,
@@ -25,27 +26,27 @@ class TopicMessageSubmitTransaction(Transaction):
 
     def __init__(
         self,
-        topic_id: Optional[basic_types_pb2.TopicID] = None,
+        topic_id: Optional[TopicId] = None,
         message: Optional[str] = None,
     ) -> None:
         """
         Initializes a new TopicMessageSubmitTransaction instance.
         Args:
-            topic_id (Optional[TopicID]): The ID of the topic.
+            topic_id (Optional[TopicId]): The ID of the topic.
             message (Optional[str]): The message to submit.
         """
         super().__init__()
-        self.topic_id: Optional[basic_types_pb2.TopicID] = topic_id
+        self.topic_id: Optional[TopicId] = topic_id
         self.message: Optional[str] = message
 
     def set_topic_id(
-        self, topic_id: basic_types_pb2.TopicID
+        self, topic_id: TopicId
     ) -> "TopicMessageSubmitTransaction":
         """
         Sets the topic ID for the message submission.
 
         Args:
-            topic_id (TopicID): The ID of the topic to which the message is submitted.
+            topic_id (TopicId): The ID of the topic to which the message is submitted.
 
         Returns:
             TopicMessageSubmitTransaction: This transaction instance (for chaining).

src/hiero_sdk_python/consensus/topic_update_transaction.py

@@ -6,13 +6,13 @@
 from google.protobuf import wrappers_pb2 as _wrappers_pb2
 from hiero_sdk_python.Duration import Duration
 from hiero_sdk_python.channels import _Channel
+from hiero_sdk_python.consensus.topic_id import TopicId
 from hiero_sdk_python.executable import _Method
 from hiero_sdk_python.hapi.services.custom_fees_pb2 import FeeExemptKeyList
 from hiero_sdk_python.hapi.services.custom_fees_pb2 import FixedCustomFeeList
 from hiero_sdk_python.timestamp import Timestamp
 from hiero_sdk_python.transaction.transaction import Transaction
 from hiero_sdk_python.hapi.services import (
-    basic_types_pb2,
     consensus_update_topic_pb2,
     duration_pb2,
     timestamp_pb2,
@@ -29,7 +29,7 @@ class TopicUpdateTransaction(Transaction):
     """Represents a transaction to update a consensus topic."""
     def __init__(
         self,
-        topic_id: Optional[basic_types_pb2.TopicID] = None,
+        topic_id: Optional[TopicId] = None,
         memo: Optional[str] = None,
         admin_key: Optional[PublicKey] = None,
         submit_key: Optional[PublicKey] = None,
@@ -43,16 +43,16 @@ def __init__(
         """
         Initializes a new instance of the TopicUpdateTransaction class.
         Args:
-            topic_id (basic_types_pb2.TopicID): The ID of the topic to update.
+            topic_id (TopicId): The ID of the topic to update.
             memo (str): The memo associated with the topic.
             admin_key (PublicKey): The admin key for the topic.
             submit_key (PublicKey): The submit key for the topic.
             auto_renew_period (Duration): The auto-renew period for the topic.
             auto_renew_account (AccountId): The account ID for auto-renewal.
-            expiration_time (timestamp_pb2.Timestamp): The expiration time of the topic.
+            expiration_time (Timestamp): The expiration time of the topic.
         """
         super().__init__()
-        self.topic_id: Optional[basic_types_pb2.TopicID] = topic_id
+        self.topic_id: Optional[TopicId] = topic_id
         self.memo: str = memo or ""
         self.admin_key: Optional[PublicKey] = admin_key
         self.submit_key: Optional[PublicKey] = submit_key
@@ -64,7 +64,7 @@ def __init__(
         self.fee_schedule_key: Optional[PublicKey] = fee_schedule_key
         self.fee_exempt_keys: Optional[List[PublicKey]] = fee_exempt_keys
 
-    def set_topic_id(self, topic_id: basic_types_pb2.TopicID) -> "TopicUpdateTransaction":
+    def set_topic_id(self, topic_id: TopicId) -> "TopicUpdateTransaction":
         """
         Sets the topic ID for the transaction.