Skip to content

Commit e1ffa96

Browse files
authored
fix: Resolve schedule_sign_transaction_e2e_test failures due to signer list mismatch (#753)
Signed-off-by: Manish Dait <[email protected]>
1 parent a919abc commit e1ffa96

File tree

2 files changed

+10
-12
lines changed

2 files changed

+10
-12
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@ This changelog is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.
5353
- Fixes a type conflict in `token_id.py` where `from_string` could receive `None`, preventing a runtime error by raising a `ValueError` if the input is missing. #630
5454
- Dependabot alerts (version bumps)
5555
- Fixed incorrect `TokenType` import (protobuf vs. SDK enum) in 18 example files.
56+
- Update `schedule_sign_transaction_e2e_test` to check for key presence instead of relying on index.
5657

5758
### Breaking Changes
5859
- chore: changed the file names airdrop classes (#631)

tests/integration/schedule_sign_transaction_e2e_test.py

Lines changed: 9 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -118,10 +118,10 @@ def test_integration_schedule_sign_transaction_can_execute_multiple_signers(env)
118118
assert schedule_info is not None
119119
assert schedule_info.schedule_id == schedule_id
120120
assert len(schedule_info.signers) == 2
121-
assert (
122-
schedule_info.signers[0].to_bytes_raw()
123-
== account.key.public_key().to_bytes_raw()
124-
)
121+
122+
signers = [s.to_bytes_raw() for s in schedule_info.signers]
123+
assert account.key.public_key().to_bytes_raw() in signers
124+
125125
assert schedule_info.executed_at is not None
126126

127127

@@ -170,14 +170,11 @@ def test_integration_schedule_sign_transaction_add_signer_later(env):
170170
assert schedule_info is not None
171171
assert schedule_info.schedule_id == schedule_id
172172
assert len(schedule_info.signers) == 2
173-
assert (
174-
schedule_info.signers[0].to_bytes_raw()
175-
== env.operator_key.public_key().to_bytes_raw()
176-
)
177-
assert (
178-
schedule_info.signers[1].to_bytes_raw()
179-
== account.key.public_key().to_bytes_raw()
180-
)
173+
174+
signers = [s.to_bytes_raw() for s in schedule_info.signers]
175+
assert env.operator_key.public_key().to_bytes_raw() in signers
176+
assert account.key.public_key().to_bytes_raw() in signers
177+
181178
assert schedule_info.executed_at is not None
182179

183180

0 commit comments

Comments
 (0)