-
Notifications
You must be signed in to change notification settings - Fork 90
Description
This issue is reserved for people who have never or only recently contributed to Hiero or any open source project in general.
We know that creating a pull request (PR) is a major barrier for new contributors.
The goal of this issue and all other issues labeled by 'good first issue' is to help you make your first contribution to Hiero.
👾 Description of the issue
Most of our examples are connecting to the hedera testnet network and run an example end to end.
For example, with token transfer, we will connect to hedera testnet, create the accounts that transfer the tokens, create the tokens, etc.
Currently, examples/custom_fee_royalty.py does not connect to the network — it only demonstrates how to construct and serialize a custom_fee_fractional object locally using the Hiero SDK.
It builds the fee object in memory, prints its fields, and shows its protobuf representation, but it does not create any accounts, tokens, or submit any transactions to the Hedera network.
💡 Solution
Connect examples/custom_fee_royalty.py to hedera testnet and create an end to end example
PLEASE ENSURE you copy functions (and make slight ammendmends if needed) from other examples/
for example:
set_up_client()
to keep consistency
💡 Implementation
To create an end to end example we need to:
- Connect to hedera
- define a custom_fee_royalty
- create a token with a custom_fee_royalty
- query the token info to check the custom_fee_royalty is applied (token_info = TokenInfoQuery().set_token_id(token_id).execute(client)
)
PLEASE REVIEW OTHER EXAMPLES/
we have examples to create a token, to query tokens. You should re-use that content and edit it slightly if needed.
Please create all necessary steps in separate functions (that are consistent with other examples), and then call them together in a final function.
👩💻 Requirements to Pass
- All examples run and tests pass
- Change has descriptive changelog.md addition to 'UNRELEASED'
e.g.
"chore: refactored examples/topic_message_submit.py to be more modular"
NOTE: ensure your branch is always up to date with upstream main !! - Verified commits achieved (see CONTRIBUTING.md and docs/sdk_developers/signing.md)
IMPORTANT Your pull request CANNOT BE MERGED until you add a changelog entry AND sign your commits each with "git commit -S -s -m "chore: your commit message"" and a GPG key***
Next steps
- Comment below that you’d like to work on this issue.
- Wait to be assigned by a maintainer.
- Read CONTRIBUTING.md
to start forking and developing.
If you have never contributed to an open source project at GitHub, the following step-by-step guide will introduce you to the workflow.