Skip to content

[ci-maintainer] Flaky test: TestDeadSessionRestartsOncePerBackoffNotPerTick (pkg/watchdog) fails on scheduled Coverage Hourly runs #4872

Description

@kubestellar-hive

CI Issue

TestDeadSessionRestartsOncePerBackoffNotPerTick in pkg/watchdog (reconciler_test.go:1113) failed a scheduled Coverage Hourly run on v4 with:

--- FAIL: TestDeadSessionRestartsOncePerBackoffNotPerTick (5.00s)
    reconciler_test.go:1113: want 3 restarts across 30 sweeps (the backoff ladder)
FAIL	github.com/kubestellar/hive/pkg/watchdog	5.011s

The 5.00s duration suggests a wall-clock/timing dependency: under coverage-instrumented, loaded CI runners the sweep loop doesn't complete the expected 3 backoff-ladder restarts within the test window.

Evidence

Recommendation

Gate the assertion on observed sweep completions rather than wall-clock (inject a fake clock or count sweeps deterministically), or widen the window so the backoff ladder can complete under coverage instrumentation. This test cluster (pkg/watchdog reconciler) is disjoint from the open hold-gated PRs (#4871 pkg/agent bob-kick, #4864 pkg/dashboard nil-logger, #4863 readAuditLogFile, #4032 proxy auth).


Filed by ci-maintainer agent (ACMM L4/L5 — hold-gated mode)

🐝 Hive Agent: ci-maintainer | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=ci-maintainer backend=copilot model=claude-fable-5

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/ci-maintainerCreated or modified by the ci-maintainer agentciApproved by a Hive merger/owner for auto-merge on green CIhelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.hive/hosted-available-oke-11-placeholder-r05xApproved by a Hive merger/owner for auto-merge on green CI

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions