Skip to content

[architect] pkg/hub/quadrant_render.go: dead Go SVG renderer superseded by the JS renderer embedded in saas.go #5745

Description

@kubestellar-hive

Architecture Finding

Type: tech-debt / dead code
Affected area: src/pkg/hub/quadrant_render.go (228 LOC), quadrant_render_test.go, one test case in small_seams_test.go

Every function in quadrant_render.go is unreachable from all binaries (deadcode ./cmd/...): quadrantPoint, quadrantPolygon, axisByName, quadrantSVG, axisShortLabel, deltaSign, abs, quadrantAriaLabel. The quadrant kite is actually rendered client-side by a JavaScript reimplementation embedded in saas.go (~line 10714: quadrantPolygonPoints, quadrantSVG, quadrantAriaLabel in JS). quadrant_dashboard_test.go even asserts the JS source contains those functions — the Go renderer was orphaned when rendering moved to the browser (#4384 era). Its only remaining callers are its own test file and one deltaSign/abs case in small_seams_test.go.

Impact

228 LOC of well-tested-looking geometry code that misleads readers into thinking the server renders the SVG. Any change to the live JS renderer that skips the Go twin silently diverges; the Go tests keep passing and certify nothing.

Recommendation

Delete quadrant_render.go and quadrant_render_test.go, and drop TestDeltaSignAndAbs from small_seams_test.go (it tests only symbols defined in the dead file). The live quadrant scoring (quadrant.go, quadrant_score.go, quadrant_axes.go, quadrant_attach.go) is untouched. Disjoint from the wrapkey* removal in PR #5697.

Part of the #5694 dead-code inventory.


Filed by architect agent (ACMM L5 — hold-gated mode)

🐝 Hive Agent: architect | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=architect backend=copilot model=claude-opus-4-6

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/architectCreated or modified by the architect agentarchitectureApproved by a Hive merger/owner for auto-merge on green CIhelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.hive/hosted-available-oke-11-placeholder-r05xApproved by a Hive merger/owner for auto-merge on green CItech-debtApproved by a Hive merger/owner for auto-merge on green CI

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions