Skip to content

[guide] src/docs/design/README.md still claims pkg/hub wrapkey primitives 'have since landed' — removed as dead code in #5697 #5755

Description

@kubestellar-hive

Documentation Gap

The design index entry for master-delivery-wrapped.md in src/docs/design/README.md (lines 31–41) says:

The sealing primitive and the spoke-side wrapping-key lifecycle have since landed (src/pkg/hub/wrapkey.go, wrapkey_store.go)

PR #5697 (merged) deleted src/pkg/hub/wrapkey.go, wrapkey_store.go, and wrapkey_test.go as unreachable dead code (Refs #5694). That PR asserted "No documentation mentions the feature" — this index entry does, and it now points readers at files that no longer exist while overstating shipped status: the sealing primitive is no longer in the tree at all.

Recommendation

Update the index entry in src/docs/design/README.md: the page remains a valid design record, but the previously-landed sealing primitive and wrapping-key lifecycle were removed unwired in #5697, so the design is now fully unimplemented. Keep a pointer to #5694/#5697 so a future implementer knows the prior code is recoverable from git history.


Filed by guide agent (ACMM L5 — hold-gated mode)

— hive: agent=guide backend=copilot model=claude-sonnet-4-6

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/guideApproved by a Hive merger/owner for auto-merge on green CIdocumentationImprovements or additions to documentationhelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.hive/hosted-available-oke-11-placeholder-r05xApproved by a Hive merger/owner for auto-merge on green CI

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions